analyze+eval: fall back to evaluating a form with less metadata
#359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
changed the title
analyze+eval: fall back to evaluating a form with less metadata when neededanalyze+eval: fall back to evaluating a form with less metadata
slipset
reviewed
Mar 27, 2021
…n needed This metadata, partly provenant from Eastwood's processing, was bloating code size, leading to "Method code too large!" exceptions. Metadata is only removed as a last resource. Fixes jonase#191
|
Rebased to use the latest test matrix. Green :) |
slipset
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This metadata, likely provenant from Eastwood's processing, was bloating code size, leading to "Method code too large!" exceptions.
...Metadata is only removed as a last resource. I also checked that basically all of the proposed metadata (
:arglists :file :line :column :end-line :end-column) has to be removed and not just a subset. I guess every byte counts!Fixes #191
Fixes #344