Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to make release with Mapbox #317

Closed
jonasoreland opened this issue Aug 31, 2015 · 7 comments
Closed

Failed to make release with Mapbox #317

jonasoreland opened this issue Aug 31, 2015 · 7 comments

Comments

@jonasoreland
Copy link
Owner

  1. First proguard failed to compile
    I added
    +-dontwarn okio.**
    +-dontwarn com.vividsolutions.jts.awt.**
    +-dontwarn android.support.**
    +-dontwarn com.squareup.okhttp.**
    +-keep class com.squareup.okhttp.** { ; }
    +-keep interface com.squareup.okhttp.
    * { *; }

  2. now it seems that the map doesnt work with the new release.
    Unclear why...

@bagage
Copy link
Contributor

bagage commented Sep 1, 2015

Even if a never used proguard i'll take a look at it until end of week...

@jonasoreland
Copy link
Owner Author

thx!

@bagage
Copy link
Contributor

bagage commented Sep 4, 2015

First thing first, proguard is total sh!t. (seriously, this tool...).
Secondly, this has been broken since #312 (commit 17d01ab) , release or not. Maybe @daverix knows what's going on there?

@bagage
Copy link
Contributor

bagage commented Sep 4, 2015

OK fix is easy, i'll do a PR.

bagage added a commit to bagage/runnerup that referenced this issue Sep 4, 2015
… (why? black magic is black magic..). Fix proguard in the mean time to solve jonasoreland#317
@jonasoreland
Copy link
Owner Author

thx!

@bagage
Copy link
Contributor

bagage commented Sep 6, 2015

Concerning the new release, could we just remove the "experimental features" settings which enables extra sports, and just use them always?
Any uploader which does not support them yet will uploads them as "Other" sport, except for Facebook which will drop them (because other not supported). In any case there will still be uploaded to all trackers, right?

@jonasoreland
Copy link
Owner Author

Hmm...that sounds reasonable.

@bagage bagage mentioned this issue Sep 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants