Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android sensors #490

Merged
merged 11 commits into from
Dec 18, 2016
Merged

Conversation

gerhardol
Copy link
Collaborator

Support internal sensors for step(cadence), temperature, pressure(elevation)
This also needed the infrastructure for those measures

The commits are split to explain some of the internal parts, but most changes are in one of the commits

Fixes that Orieenteering is handled as Running rather than Other in .tcx, Google Fit
The main benefit is though a cleanup in the handling of the raw dbValues like DB.ACTIVITY.SPORT_RUNNING
The enabling of sporttypes had a big uncertainity here, many manual checks (the cleanup was partial, I had done a little separately that is now separated)

As there is more or less one-to-one mapping dbValue to Sport, it is still not easy to add new sporttypes, but at least the db value is checked.
Remove Eclipse specific from .gitignore
Cadence changed from integer to real (OK in SQLite, field is not used)
Good to see the elevation stabilizing to get good accuracy
Even more important when using barometer elevation, it is calibrated to GPS elevation
…sors

Support for cadence/temperature/pressure-elevation affects many files
Separate TrackerElevation that selects GPS or barometer depending on configuration
Creator set in gpx/tcx export if pressure was available when recording
Strava exports temperature but do not display it
Tune Garmin GPX extensions to upload cadence etc too
Support Cluetrust GPX extensions (Cluetrust is not fully working to Strava)
@jonasoreland
Copy link
Owner

very cool!

  1. i agree that this will have to wait until i made release
  2. can you rebase it ? i see lots of stuff that I already merged, and patch
    looks big anyway.

@gerhardol
Copy link
Collaborator Author

gerhardol commented Dec 5, 2016

The PR is based on the second to last commit in master, actually on PR #486 (uses some of those changes).
(The master update was done just before I pushed the branch.)
So a rebase would only remove one commit (and require a new PR).
The original branch had some hundred+ commits, rebase/squash was manual to comment/document the changes.

Edit: Yes, the patch is big. Most cannot be separated.

# Conflicts:
#	.travis.yml
#	build.gradle
@jonasoreland jonasoreland merged commit a873ef3 into jonasoreland:master Dec 18, 2016
@gerhardol gerhardol deleted the android-sensors-merge branch December 20, 2016 22:41
gerhardol added a commit to gerhardol/runnerup that referenced this pull request Dec 25, 2016
gerhardol added a commit to gerhardol/runnerup that referenced this pull request Dec 25, 2016
@gerhardol gerhardol mentioned this pull request Dec 25, 2016
@gerhardol gerhardol mentioned this pull request Feb 4, 2017
@gerhardol gerhardol mentioned this pull request Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants