Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunKeeper remove feed #608

Merged
merged 18 commits into from Aug 10, 2017

Conversation

gerhardol
Copy link
Collaborator

The feed required a separate authentication that failed and gave the impression that RK did not work at all

Has been broken a few years
Used fitnesskeeperapi.com (was this official?). Feed for friends is not included in the normal API
Just confusing to keep

Based on #599

When rebuilding without updating the database, the resource ids can get out of sync with the database. This will either give incorrect icon or more likely an exception.
FORMAT only used by FileSynchronizer
AUTH_METHOD not used at all
Omitted setting of them where unused
Possibility to show disabled accounts in the account list, from the menu.
Uploaded still shows
Hide disabled (not configured) Workout provider (Garmin)
… URL no longer used

All but File,Runalyze had the field hardcoded internally, RunAlyze did not change the displayed URL and File had extra handling
AUTH_NOTICE, FLAGS was not in the database at that time
Extremely chatty right now (I thought something were wrong with it).
Decreased from Debug to Verbose for most
Some html responses suppressed
Database was prepared for external ID handling, but bot the SyncManager as the handling must be done in the background
Used fitnesskeeperapi.com (was this official?). Feed for friends is not included in the normal API
Just confusing to keep
@gerhardol gerhardol mentioned this pull request Aug 10, 2017
@gerhardol gerhardol added this to the Classic_Next milestone Aug 10, 2017
@gerhardol gerhardol mentioned this pull request Aug 10, 2017
@gerhardol gerhardol merged commit 23a5ccc into jonasoreland:master Aug 10, 2017
@gerhardol gerhardol deleted the pr/runkeeper-remove-feed branch August 10, 2017 21:16
@gerhardol gerhardol mentioned this pull request Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants