New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RunKeeper remove feed #608
Merged
gerhardol
merged 18 commits into
jonasoreland:master
from
gerhardol:pr/runkeeper-remove-feed
Aug 10, 2017
Merged
RunKeeper remove feed #608
gerhardol
merged 18 commits into
jonasoreland:master
from
gerhardol:pr/runkeeper-remove-feed
Aug 10, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When rebuilding without updating the database, the resource ids can get out of sync with the database. This will either give incorrect icon or more likely an exception.
FORMAT only used by FileSynchronizer AUTH_METHOD not used at all Omitted setting of them where unused
Possibility to show disabled accounts in the account list, from the menu. Uploaded still shows Hide disabled (not configured) Workout provider (Garmin)
… URL no longer used All but File,Runalyze had the field hardcoded internally, RunAlyze did not change the displayed URL and File had extra handling
AUTH_NOTICE, FLAGS was not in the database at that time
Extremely chatty right now (I thought something were wrong with it). Decreased from Debug to Verbose for most Some html responses suppressed
Database was prepared for external ID handling, but bot the SyncManager as the handling must be done in the background
…nks in the detailed activity account list
Used fitnesskeeperapi.com (was this official?). Feed for friends is not included in the normal API Just confusing to keep
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feed required a separate authentication that failed and gave the impression that RK did not work at all
Has been broken a few years
Used fitnesskeeperapi.com (was this official?). Feed for friends is not included in the normal API
Just confusing to keep
Based on #599