pkp/pkp-lib#8700 Dropped safeCount() workaround in favor of getCountF…

…orPagination() (cherry picked from commit 4648a75)
jonasraoni · May 23, 2024 · 957076e · 957076e
1 parent e6dc902
commit 957076e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/classes/doi/Repository.php b/classes/doi/Repository.php
@@ -161,7 +161,7 @@ public function isAssigned(int $doiId, string $pubObjectType): bool
                 ->getCollector()
                 ->filterByDoiIds([$doiId])
                 ->getQueryBuilder()
-                ->safeCount() > 0,
+                ->getCountForPagination() > 0,
             default => false,
         };
 

diff --git a/classes/services/queryBuilders/GalleyQueryBuilder.php b/classes/services/queryBuilders/GalleyQueryBuilder.php
@@ -60,11 +60,11 @@ public function getCount()
     {
         return $this
             ->getQuery()
-            ->safeCount();
+            ->getCountForPagination();
     }
 
     /**
-     * @copydoc PKP\services\queryBuilders\interfaces\EntityQueryBuilderInterface::getCount()
+     * @copydoc PKP\services\queryBuilders\interfaces\EntityQueryBuilderInterface::getIds()
      */
     public function getIds()
     {
@@ -76,7 +76,8 @@ public function getIds()
     }
 
     /**
-     * @copydoc PKP\services\queryBuilders\interfaces\EntityQueryBuilderInterface::getCount()
+     * @copydoc PKP\services\queryBuilders\interfaces\EntityQueryBuilderInterface::getQuery()
+     *
      * @hook Galley::getMany::queryObject [[&$q, $this]]
      */
     public function getQuery()