Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define __matmul__ operator. #37

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Conversation

eserie
Copy link
Contributor

@eserie eserie commented Apr 20, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #37 (cf6696a) into master (4656839) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #37   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1753      1743   -10     
=========================================
- Hits          1753      1743   -10     
Impacted Files Coverage Δ
eagerpy/tensor/jax.py 100.00% <ø> (ø)
eagerpy/tensor/numpy.py 100.00% <ø> (ø)
eagerpy/tensor/pytorch.py 100.00% <ø> (ø)
eagerpy/tensor/tensorflow.py 100.00% <ø> (ø)
eagerpy/tensor/tensor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4656839...cf6696a. Read the comment docs.

@jonasrauber
Copy link
Owner

Nice, this allows us to get rid of the framework-specific code duplication for matmul 👍
I guess this breaks compatibility with some older versions of PyTorch, TensorFlow, NumPy that didn't support __matmul__, but I think we can live with that.

@jonasrauber jonasrauber merged commit 6fa4c79 into jonasrauber:master Apr 28, 2021
@jonasrauber
Copy link
Owner

resolves #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants