Move uiInterface.NotifyBlockTip signal above the core/wallet signal

- This will keep getbestblockhash more in sync with blocknotify callbacks
jonasschnelli · Nov 30, 2015 · 9af5f9c · 9af5f9c
1 parent 4082e46
commit 9af5f9c
Showing 1 changed file with 31 additions and 28 deletions.
diff --git a/src/main.cpp b/src/main.cpp
@@ -2606,40 +2606,43 @@ bool ActivateBestChain(CValidationState &state, const CChainParams& chainparams,
         // When we reach this point, we switched to a new tip (stored in pindexNewTip).
 
         // Notifications/callbacks that can run without cs_main
-        if (!fInitialDownload) {
-            // Find the hashes of all blocks that weren't previously in the best chain.
-            std::vector<uint256> vHashes;
-            CBlockIndex *pindexToAnnounce = pindexNewTip;
-            while (pindexToAnnounce != pindexFork) {
-                vHashes.push_back(pindexToAnnounce->GetBlockHash());
-                pindexToAnnounce = pindexToAnnounce->pprev;
-                if (vHashes.size() == MAX_BLOCKS_TO_ANNOUNCE) {
-                    // Limit announcements in case of a huge reorganization.
-                    // Rely on the peer's synchronization mechanism in that case.
-                    break;
+        // Always notify the UI if a new block tip was connected
+        if (pindexFork != pindexNewTip) {
+            uiInterface.NotifyBlockTip(fInitialDownload, pindexNewTip);
+
+            if (!fInitialDownload) {
+                // Find the hashes of all blocks that weren't previously in the best chain.
+                std::vector<uint256> vHashes;
+                CBlockIndex *pindexToAnnounce = pindexNewTip;
+                while (pindexToAnnounce != pindexFork) {
+                    vHashes.push_back(pindexToAnnounce->GetBlockHash());
+                    pindexToAnnounce = pindexToAnnounce->pprev;
+                    if (vHashes.size() == MAX_BLOCKS_TO_ANNOUNCE) {
+                        // Limit announcements in case of a huge reorganization.
+                        // Rely on the peer's synchronization mechanism in that case.
+                        break;
+                    }
                 }
-            }
-            // Relay inventory, but don't relay old inventory during initial block download.
-            int nBlockEstimate = 0;
-            if (fCheckpointsEnabled)
-                nBlockEstimate = Checkpoints::GetTotalBlocksEstimate(chainparams.Checkpoints());
-            {
-                LOCK(cs_vNodes);
-                BOOST_FOREACH(CNode* pnode, vNodes) {
-                    if (chainActive.Height() > (pnode->nStartingHeight != -1 ? pnode->nStartingHeight - 2000 : nBlockEstimate)) {
-                        BOOST_REVERSE_FOREACH(const uint256& hash, vHashes) {
-                            pnode->PushBlockHash(hash);
+                // Relay inventory, but don't relay old inventory during initial block download.
+                int nBlockEstimate = 0;
+                if (fCheckpointsEnabled)
+                    nBlockEstimate = Checkpoints::GetTotalBlocksEstimate(chainparams.Checkpoints());
+                {
+                    LOCK(cs_vNodes);
+                    BOOST_FOREACH(CNode* pnode, vNodes) {
+                        if (chainActive.Height() > (pnode->nStartingHeight != -1 ? pnode->nStartingHeight - 2000 : nBlockEstimate)) {
+                            BOOST_REVERSE_FOREACH(const uint256& hash, vHashes) {
+                                pnode->PushBlockHash(hash);
+                            }
                         }
                     }
                 }
-            }
-            // Notify external listeners about the new tip.
-            if (!vHashes.empty()) {
-                GetMainSignals().UpdatedBlockTip(pindexNewTip);
+                // Notify external listeners about the new tip.
+                if (!vHashes.empty()) {
+                    GetMainSignals().UpdatedBlockTip(pindexNewTip);
+                }
             }
         }
-        // Always notify the UI if a new block tip was connected
-        uiInterface.NotifyBlockTip(fInitialDownload, pindexNewTip);
     } while(pindexMostWork != chainActive.Tip());
     CheckBlockIndex(chainparams.GetConsensus());