-
Notifications
You must be signed in to change notification settings - Fork 356
Date dropdown clear buttons, keyboard support #148
Conversation
Thank you! I'll have a look at it later. |
This doesn't really work. Well, it kind of does, but If I try to manually edit the year the cursor jumps back to the end and a request is made to the server, which results in a Bad Request 400. I'd rather much like the request to be made when I'm done typing. Maybe we should try using the other date selection inputs, the one I've also used on the document editing form. |
Hmm, shouldn’t submit unless date is valid. Lemme look...
… On Dec 17, 2020, at 1:03 PM, Jonas Winkler ***@***.***> wrote:
This doesn't really work. Well, it kind of does, but If I try to manually edit the year the cursor jumps back to the end and a request is made to the server, which results in a Bad Request 400. I'd rather much like the request to be made when I'm done typing.
Maybe we should try using the other date selection inputs, the one I've also used on the document editing form.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Or rather, until exiting the field (or pressing enter). |
Ok I think I sorted it all. Also added a little visual feedback if the keyboard input is not a valid date and made it only submit on 'Enter' |
When I select a date with the quick filters, close the drop down, clear all filters with the rightmost button, the dates don't get properly cleared. Open up the drop down again, and the list view reloads with the filter active again. Very strange. |
Ok last commit should fix that hopefully. |
Alright, I've replaced the That should wrap up this issue. Edit: I've included both the per-field clear buttons and the changed order of both input fields. |
This PR closes #144 , it adds: