Support for 'any' vs 'all' as well as 'not' filtering for tags #399

shamoon · 2021-01-21T01:11:38Z

This PR addresses part of #356 as well as closes #401 by adding support for changing tag filtering from its current "All" to allow "Any" as well as adding support for NOT (option-click).

any_all_not.mov

@jonaswinkler I found tags__id__in in the API so thought it wouldn't be such a big deal but one thing is that the API is returning duplicate documents when they have multiple tags (e.g. document has tag 1 & tag 2, search for tag 1 or tag 2 it returns that doc twice). Im no Django expert, thought I could resolve with something like:
~~Thoughts on that issue (or other feedback of course)?~~

Edit: think that issue is sorted, welcome your feedback in general

shamoon · 2021-01-21T02:35:51Z

Oh, duh, distinct()!

Ok, let me know what you think when you have a moment.

…e it

shamoon · 2021-01-21T03:42:16Z

src-ui/src/app/components/document-list/filter-editor/filter-editor.component.ts

@@ -199,15 +204,15 @@ export class FilterEditorComponent implements OnInit, OnDestroy {
  }

  toggleTag(tagId: number) {
-    this.tagSelectionModel.toggle(tagId)
+    this.tagSelectionModel.set(tagId, ToggleableItemState.Selected)


These are a fix that I just included, clicking a tag/dt/corresp should always enable that item, not remove it (because if that tag was already selected the document you just clicked disappears which doesnt make sense IMHO)

jonaswinkler · 2021-01-21T11:09:10Z

See aeb10d3

jonaswinkler · 2021-01-21T12:50:58Z

I'd also like to consider this: #401

shamoon · 2021-01-21T16:30:36Z

Hmm, increasing complexity for our humble dropdowns. So I guess for "not" we could implement something similar with the ⌥ modifier key (though as in the GH UI you have to tell the user somehow since its totally not obvious). But this feature could also just remain as-is. So you can switch from "label 1 AND not label2" to "label 1 OR not label2". Right?

Would you prefer adding that into this PR or merging this one and I can work on "not" separately? (version control wise I think smaller PRs are better but thats just my opinion, happy either way).

shamoon · 2021-01-21T16:59:30Z

TBH I'm not sure exactly how to tackle "not", I have to think about it some. You'd need something like a filter rule for each selected tag +/- that are then joined by AND vs OR but then it'd be like "(tag
1 OR not tag2) AND correspondent1" etc right? But currently OR for tags is 1 rule...

jonaswinkler · 2021-01-21T17:02:30Z

Hmm, increasing complexity for our humble dropdowns

I don't like it either, will have to think about that.

So you can switch from "label 1 AND not label2" to "label 1 OR not label2". Right?

I'm not sure yet how compatible these two features are. Will have to think about that. Querying for "label1 OR not label2" ~~is most certainly not possible.~~ will require new filtering mechanisms, and the logic for that isn't very straight forward. I'm concerned that the logic of the drop downs won't be very intuitive with both these feature.

shamoon · 2021-01-21T17:47:08Z

Yeah at some point we have to ask ourselves if cramming everything into this one place is the best way to do it. But I also don't love the idea of having to support an entirely different place for managing "advanced" filters or something like that.

Without real 'evidence' my suspicion is that "any/all" would get more use than "not" as its been requested more than once and I have on occasion found myself looking for that in my own usage.

But yea, TBD...

shamoon · 2021-01-21T18:00:42Z

Sorry for all the comments. One other thought would be to just disable the "any/all" toggle if any tags are set to "not". Obviously still the challenge of implementing "not" in general, but this would reduce the complexity overall

shamoon · 2021-01-21T19:04:04Z

Hey FYI I have a branch that has "not" working pretty well (needs a little tweaking): https://github.com/shamoon/paperless-ng/tree/fix/issue-401

Let me know thoughts about these two features and we can figure out from there.

shamoon · 2021-01-21T22:38:58Z

I saw you pushed 1.0, nice!

One last update: I merged my branch for "not" into this one (I haven't committed this cause will wait on your thoughts) and honestly I think it works well. I have the any / all toggle disable if items are excluded. It seems like a pretty specific subset of use cases where someone wants the ability to "tag1 OR not tag2" and I think its better to ship these two features than spend time on all that for that small gain.

Let me know, I can commit these changes so you can test everything together or whatever you think.

shamoon · 2021-01-23T17:40:07Z

Went ahead and pushed commits described above. Let me know if any issues with this approach or if youre just too dang busy I get it!

jonaswinkler · 2021-01-23T18:21:51Z

Thanks for all the effort! I still need to look into this.

Without real 'evidence' my suspicion is that "any/all" would get more use than "not" as its been requested more than once and I have on occasion found myself looking for that in my own usage

Not sure. I've seen both mentioned one or two times, which is not alot.

Also: Not sure how this will play out with nested tags. I'd say it's wise to postpone this PR until that's figured out.

shamoon · 2021-01-23T18:51:31Z

Also: Not sure how this will play out with nested tags. I'd say it's wise to postpone this PR until that's figured out.

Obviously your call, you da boss. I didn't realize nested tags was this close but I guess we're at 1.0 so =)
In my very rough conception of nested tags I imagined they'd be essentially a parent is like an "alias" to children, so searching for parent id also just includes its children (at the API level). In that case having any / all and NOT still wouldn't really be a problem i.e. you can search for parent but exclude one of its children, no? UI-wise there are definitely going to be some challenges / decisions to make. Anyway, no reason to get into the weeds here.

As I mentioned in other issues, I enjoy helping out so let me know where I might be useful with nested tags or whatever else.

jonaswinkler · 2021-06-13T15:09:18Z

src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.ts

@@ -15,6 +15,8 @@ export class FilterableDropdownSelectionModel {
  changed = new Subject<FilterableDropdownSelectionModel>()

  multiple = false
+  private _logicalOperator = 'and'


Codacy has a fix for the issue: Strings must use doublequote.

Suggested change

private _logicalOperator = 'and'

private _logicalOperator = "and"

jonaswinkler · 2021-06-13T15:09:19Z

src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.ts

@@ -43,6 +45,10 @@ export class FilterableDropdownSelectionModel {
    return this.items.filter(i => this.temporarySelectionStates.get(i.id) == ToggleableItemState.Selected)
  }

+  getExcludedItems() {
+    return this.items.filter(i => this.temporarySelectionStates.get(i.id) == ToggleableItemState.Excluded)


Codacy has a fix for the issue: Expected parentheses around arrow function argument.

Suggested change

return this.items.filter(i => this.temporarySelectionStates.get(i.id) == ToggleableItemState.Excluded)

return this.items.filter((i) => this.temporarySelectionStates.get(i.id) == ToggleableItemState.Excluded)

When set, the user is redirected to this URL after a logout. Especially useful in conjunction with PAPERLESS_ENABLE_HTTP_REMOTE_USER and SSO.

This fixes the ansible role for installing paperless-ng where the config item PAPERLESS_TIKA_GOTENBERG_ENDPOINT derived from the wrong ansible variable "paperlessng_tika_endpoint". This patch corrects that to "paperlessng_tika_gotenberg_endpoint".

Clarified exactly what to change to modify the default webserver port (issue #1273)

Updated docker instructions re webserver port

…ndpoint Fix PAPERLESS_TIKA_GOTENBERG_ENDPOINT in a/t/main.yml

Add PAPERLESS_LOGOUT_REDIRECT_URL

Incorrect path to docker-compose files

martin-v · 2021-10-20T09:38:48Z

Thanks for your work! @shamoon @jonaswinkler but is there any change to get this merged? It would be still an important feature.

shamoon added 3 commits January 20, 2021 15:21

Add support for 'any' ('OR') of tags when filtering

861b2ef

changed event for toggling operator

79059b9

Update API filters for "any" tag_id

893dcd9

shamoon marked this pull request as ready for review January 21, 2021 02:35

shamoon added 4 commits January 20, 2021 18:38

Fix resetting any vs all

8f08201

Disable any/all toggle when not needed

3766d86

Remove unused interface

ff8eb7f

Clicking card tag/dt/corresp should always add that item, never remov…

cde867c

…e it

shamoon commented Jan 21, 2021

View reviewed changes

refactor

3e0c3c0

Support excluding tags

29a7737

shamoon added 5 commits January 21, 2021 11:09

Prevent exclude click in editing (bulk editor) mode

795dbc1

Prevent download when alt-click tags

9ac1941

Add UI hint for option-click

c926e02

Fix unable to save ANY views

d7cefab

Merge branch 'fix/issue-401' into feature/any-all-filtering

14d04ff

shamoon added 2 commits January 21, 2021 14:41

return key works too

a73ff4f

Disable any / all toggle when excluded items

a6bd118

shamoon changed the title ~~Support for 'any' vs 'all' filtering for tags~~ Support for 'any' vs 'all' as well as 'not' filtering for tags Jan 23, 2021

Shrink dropdown note font size to fit on one line

a5edbcf

jonaswinkler reviewed Jun 13, 2021

View reviewed changes

tribut and others added 8 commits August 26, 2021 18:40

Add PAPERLESS_LOGOUT_REDIRECT_URL

bf2cdae

When set, the user is redirected to this URL after a logout. Especially useful in conjunction with PAPERLESS_ENABLE_HTTP_REMOTE_USER and SSO.

Updated docker instructions re webserver port

12abb59

Clarified exactly what to change to modify the default webserver port (issue #1273)

Merge pull request #1274 from padraigkitterick/patch-1

4e9c4eb

Updated docker instructions re webserver port

Merge pull request #1270 from ajkavanagh/fix-ansible-role-gotenberg-e…

32f0eba

…ndpoint Fix PAPERLESS_TIKA_GOTENBERG_ENDPOINT in a/t/main.yml

Merge pull request #1258 from tribut/logout-url

d656de8

Add PAPERLESS_LOGOUT_REDIRECT_URL

Incorrect path to docker-compose files

2aca64b

Merge pull request #1311 from mattlamb99/patch-1

7bc8325

Incorrect path to docker-compose files

shamoon mentioned this pull request Feb 15, 2022

Feature: any / all filtering with tags paperless-ngx/paperless-ngx#10

Merged

shamoon added 6 commits February 14, 2022 22:23

Merge branch 'dev' into feature/any-all-filtering

f75d4cc

Update filter-rule-type.ts

da361e9

Fix spelling error

250575a

Change alt-click to second click

1ba1df2

Hide double-click note on non-multiple dropdowns

0b6c749

Indicate disabled but active All button

c945b90

shamoon closed this Jun 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for 'any' vs 'all' as well as 'not' filtering for tags #399

Support for 'any' vs 'all' as well as 'not' filtering for tags #399

shamoon commented Jan 21, 2021 •

edited

Loading

shamoon commented Jan 21, 2021

shamoon Jan 21, 2021 •

edited

Loading

jonaswinkler commented Jan 21, 2021

jonaswinkler commented Jan 21, 2021

shamoon commented Jan 21, 2021

shamoon commented Jan 21, 2021

jonaswinkler commented Jan 21, 2021 •

edited

Loading

shamoon commented Jan 21, 2021

shamoon commented Jan 21, 2021

shamoon commented Jan 21, 2021

shamoon commented Jan 21, 2021

shamoon commented Jan 23, 2021

jonaswinkler commented Jan 23, 2021

shamoon commented Jan 23, 2021

jonaswinkler Jun 13, 2021

jonaswinkler Jun 13, 2021

martin-v commented Oct 20, 2021

	private _logicalOperator = 'and'
	private _logicalOperator = "and"

	return this.items.filter(i => this.temporarySelectionStates.get(i.id) == ToggleableItemState.Excluded)
	return this.items.filter((i) => this.temporarySelectionStates.get(i.id) == ToggleableItemState.Excluded)

Support for 'any' vs 'all' as well as 'not' filtering for tags #399

Support for 'any' vs 'all' as well as 'not' filtering for tags #399

Conversation

shamoon commented Jan 21, 2021 • edited Loading

shamoon commented Jan 21, 2021

shamoon Jan 21, 2021 • edited Loading

Choose a reason for hiding this comment

jonaswinkler commented Jan 21, 2021

jonaswinkler commented Jan 21, 2021

shamoon commented Jan 21, 2021

shamoon commented Jan 21, 2021

jonaswinkler commented Jan 21, 2021 • edited Loading

shamoon commented Jan 21, 2021

shamoon commented Jan 21, 2021

shamoon commented Jan 21, 2021

shamoon commented Jan 21, 2021

shamoon commented Jan 23, 2021

jonaswinkler commented Jan 23, 2021

shamoon commented Jan 23, 2021

jonaswinkler Jun 13, 2021

Choose a reason for hiding this comment

jonaswinkler Jun 13, 2021

Choose a reason for hiding this comment

martin-v commented Oct 20, 2021

shamoon commented Jan 21, 2021 •

edited

Loading

shamoon Jan 21, 2021 •

edited

Loading

jonaswinkler commented Jan 21, 2021 •

edited

Loading