Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add routerConfig #2643

Merged
merged 2 commits into from
Feb 27, 2023
Merged

add routerConfig #2643

merged 2 commits into from
Feb 27, 2023

Conversation

Riadloc
Copy link
Contributor

@Riadloc Riadloc commented Dec 9, 2022

issue #2610 #2545

flutter official commit here

@mitesh77
Copy link

we can use with go_route package after this add routerConfig @Riadloc @Ajjig ?

@duc1205
Copy link

duc1205 commented Feb 14, 2023

@Riadloc what you added just to make it look like go_router but not usable?

@Riadloc
Copy link
Contributor Author

Riadloc commented Feb 14, 2023

@duc1205 because this pr not merged yet. 😂

@duc1205
Copy link

duc1205 commented Feb 14, 2023

@Riadloc i see you are just giving getx's getpage the same as go_router. is that true?

@duc1205
Copy link

duc1205 commented Feb 14, 2023

@jonataslaw

@jonataslaw
Copy link
Owner

Thanks for your contribution
LGTM

@jonataslaw jonataslaw merged commit ddd0b84 into jonataslaw:master Feb 27, 2023
@duc1205
Copy link

duc1205 commented Feb 27, 2023

when release 5.0 @jonataslaw ?

@duc1205
Copy link

duc1205 commented Jun 1, 2023

@jonataslaw when use go_router in getx master, i see Getx required add getPages
image

@mbfakourii
Copy link

@jonataslaw when use go_router in getx master, i see Getx required add getPages image

and get You need add pages or home !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants