remove UNKNOWN_ERROR from the list of PositionError.code can take #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathantneal
added a commit
that referenced
this pull request
Oct 14, 2011
remove UNKNOWN_ERROR from the list of PositionError.code can take
|
Fantastic myakura, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/myakura/diveintohtml5/blob/master/geolocation.html#L144 says:
However, UNKNOWN_ERROR was removed from the specification long time ago.
http://www.w3.org/2009/11/02-geolocation-minutes.html
And Gecko and WebKit already removed their impls to match the spec.
http://hg.mozilla.org/mozilla-central/rev/c3924062e8bc
http://trac.webkit.org/changeset/50605
So I don't think there's any need to mention about the constant.