Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize .min files #123

Merged
merged 2 commits into from
Sep 26, 2016
Merged

Optimize .min files #123

merged 2 commits into from
Sep 26, 2016

Conversation

jontonsoup4
Copy link
Contributor

Description

Optimizes .min files by removing comments and whitespace. Also fixes a typo in the README.

Before After
svg4everybody.min.js 2.84 KB 1.55 KB
svg4everybody.legacy.min.js 3.67 KB 2.13 KB

@@ -1,2 +1,3 @@
node_modules
npm-debug.log
.idea
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this belongs in your user-level gitignore.

@shawnbot
Copy link
Collaborator

Thank you, @jontonsoup4! As soon as I'm in front of a real computer I'll give this a closer look. In the meantime, can you remove the .idea line from .gitignore?

@jontonsoup4
Copy link
Contributor Author

Done!

@jontonsoup4
Copy link
Contributor Author

@shawnbot Did you ever get a chance to look at this PR?

Copy link
Collaborator

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long to do this, @jontonsoup4! This looks great, and 👍 on adding mangle to the minified version.

@shawnbot shawnbot merged commit 6cf7288 into jonathantneal:master Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants