Add support for fake tickers #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello Jon, |
| @@ -12,6 +12,7 @@ type Clock interface { | |||
| Sleep(d time.Duration) | |||
| Now() time.Time | |||
| Since(t time.Time) time.Duration | |||
| NewTicker(d time.Duration) Ticker | |||
There was a problem hiding this comment.
This is technically not following the exact definition of NewTicker from the stdlib. There it is func NewTicker(d Duration) *Ticker. But I don't know if this is a concern
edit: I just realized that Ticker is an interface. Sorry about the confusion
Closed
|
LGTM. Sorry about the horrendous delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spend a little time on extending your library to add support for fake tickers.
Currently this requires surrounding the Advance() calls with BlockUntil() to make sure that the ticker can go to sleep before Advance() is called and afterwards wake up before we start consuming ticks.
Let me know what you think.