Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/stabilize tests #116

Merged
merged 4 commits into from
Apr 9, 2015
Merged

Chore/stabilize tests #116

merged 4 commits into from
Apr 9, 2015

Conversation

rud
Copy link
Contributor

@rud rud commented Apr 9, 2015

A few minor corrections:

  • letting Travis CI pick current ruby-versions in each version-series (2.2, 2.1, etc)
  • use .fetch to highlight where a nil was coming from
  • only one setup block is run at each level of test; this fixes a few unstable tests. Running SEED=19690 rake previously failed, all is well now.

rud added 4 commits April 9, 2015 10:35
@rud
CI: run on latest 2.2.x and 2.1.x ruby
8ee580b
@rud
CI: let Travis pick minor version
ad99c53
@rud
Queue#subscribe: use .fetch to avoid getting a useless nil
8e48ff3 
This is part of stabilizing the specs, currently fails when run like this:
`SEED=19690 rake`
@rud
Minitest: only the last before-block is kept
247f1c7 
This should stabilize the test as configuration is now run before each test.
@rud rud mentioned this pull request Apr 9, 2015
Merged
@jondot jondot merged commit 247f1c7 into jondot:master Apr 9, 2015
@jondot
Copy link
Owner

jondot commented Apr 9, 2015

Fantastic work! :) 👍 👍

@rud rud deleted the chore/stabilize-tests branch April 10, 2015 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rud @jondot