dotnet#1638: use .SpecialType to check for string

jongleur1983 · Oct 13, 2018 · d805096 · d805096
1 parent 16a18fe
commit d805096
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/...deQuality.Analyzers/Core/ApiDesignGuidelines/StringBuilderAppendShouldNotTakeSubstring.cs b/...deQuality.Analyzers/Core/ApiDesignGuidelines/StringBuilderAppendShouldNotTakeSubstring.cs
@@ -95,9 +95,8 @@ private void Action(OperationAnalysisContext context)
                         if (argument.Value is IInvocationOperation invocationExpression
                             && invocationExpression.TargetMethod is IMethodSymbol parameterMethod
                             && parameterMethod.Name == nameof(String.Substring)
-                            && parameterMethod.ContainingSymbol.Name == nameof(String)
-                            && parameterMethod.ContainingSymbol.ContainingNamespace.Name == nameof(System)
-                            && parameterMethod.ContainingSymbol.ContainingNamespace.ContainingNamespace.IsGlobalNamespace)
+                            && parameterMethod.ContainingSymbol is INamedTypeSymbol parameterMethodOwner
+                            && parameterMethodOwner.SpecialType == SpecialType.System_String)
                         {
                             switch (parameterMethod.Parameters.Length)
                             {