Use list comprehension

[c3ho]

detectURL/detectURL.py

Lines 33 to 36 in 695ab05

	for line in file:
	url = re.findall('https?://(?:[-\w.]|(?:%[\da-fA-F]{2}))+', line)
	if url:
	urls += url

Hey, if you're ever interested in trying out list comprehension here's a stackoverflow thing you can look into making it a one-liner
https://stackoverflow.com/questions/52286057/list-comprehension-with-if-condition-in-python

 for line in file: 
     url = re.findall('https?://(?:[-\w.]|(?:%[\da-fA-F]{2}))+', line) 
     if url: 
         urls += url 

to something like

urls = [line for line in file if re.findall('https?://(?:[-\w.]|(?:%[\da-fA-F]{2}))+', line)]

[jongwon-jang]

Thank you so much for the advice.
I'll try this way

[c3ho]

Almost there, I tested the urls = [line for line in file if re.findall(r"https?://(?:[-\w.]|(?:%[\da-fA-F]{2}))+", line)] and it should work

def initialize():

    with open(sys.argv[1]) as file:
       #The [code here] part creates an array/list so no need to append
       #We're pretty much saying for each line in the file if it matches the regex we have, append it to a temp array/list then 
          assign the whole array/list to urls
        urls = [line for line in file if re.findall(r"https?://(?:[-\w.]|(?:%[\da-fA-F]{2}))+", line)]
        
        for link in urls:
            //rest of code