Move dependent code inside with block

[c3ho]

detectURL/detectURL.py

Lines 32 to 54 in 695ab05

	with open(sys.argv[1]) as file:
	for line in file:
	url = re.findall('https?://(?:[-\w.]|(?:%[\da-fA-F]{2}))+', line)
	if url:
	urls += url
	final_urls = list(dict.fromkeys(urls)) # Remove Duplicates
	for link in final_urls:
	try:
	r = requests.get(link, timeout=1.5)
	if r.status_code == 200:
	print(Fore.GREEN + "GOOD - " + str(link))
	r.raise_for_status()
	except requests.exceptions.HTTPError as e:
	status_code = e.response.status_code
	if status_code == 400 or 404:
	print(Fore.RED + "BAD - " + link)
	else:
	print(Fore.WHITE + "UNKNOWN - " + link)
	except requests.exceptions.ConnectionError:
	print(Fore.WHITE + "UNKNOWN - " + link)
	except requests.exceptions.Timeout:
	print(Fore.RED + "BAD - " + link)

Since everything is dependent on a file or the opening of a file, wouldn't it be better to move everything inside whether the file is opened? So anything from Line 37 onwards should be inside the Line 32 block