Skip to content

Commit

Permalink
Fix dependencies
Browse files Browse the repository at this point in the history
Gradle `compile` configuration exposes the dependencies used by the
project to consumers, by replacing it with `implementation` this
behaviour changed.

The `implementation` configuration only exposes
that library to the compile and runtime classpath, but consumers
don't have access to it. As some projects used previously `compile`
exposed libraries, we need to supply those explicitly when using
the `implementation` configuration.
  • Loading branch information
jonhkr committed Sep 6, 2020
1 parent 2aa5c65 commit 514a722
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions build.gradle
Expand Up @@ -965,6 +965,7 @@ project(':examples') {

dependencies {
implementation project(':core')
implementation libs.scalaLibrary
implementation project(':clients')
}

Expand Down Expand Up @@ -1131,6 +1132,7 @@ project(':tools') {
implementation libs.jacksonDatabind
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.log4j

implementation libs.jacksonJaxrsJsonProvider
implementation libs.jerseyContainerServlet
Expand Down Expand Up @@ -1193,6 +1195,7 @@ project(':streams') {
testImplementation project(':clients').sourceSets.test.output
testImplementation project(':core')
testImplementation project(':core').sourceSets.test.output
testImplementation libs.scalaLibrary
testImplementation libs.log4j
testImplementation libs.junit
testImplementation libs.easymock
Expand Down Expand Up @@ -1314,6 +1317,8 @@ project(':streams:streams-scala') {
archivesBaseName = "kafka-streams-scala_${versions.baseScala}"

dependencies {

implementation project(':clients')
implementation project(':streams')

implementation libs.scalaLibrary
Expand Down Expand Up @@ -1358,6 +1363,7 @@ project(':streams:test-utils') {
dependencies {
implementation project(':streams')
implementation project(':clients')
implementation libs.slf4jApi

testImplementation project(':clients').sourceSets.test.output
testImplementation libs.junit
Expand Down Expand Up @@ -1391,7 +1397,9 @@ project(':streams:examples') {

dependencies {
implementation project(':streams')
implementation project(':clients')
implementation project(':connect:json') // this dependency should be removed after we unify data API
implementation libs.jacksonDatabind
implementation libs.slf4jlog4j

testImplementation project(':streams:test-utils')
Expand Down Expand Up @@ -1690,6 +1698,7 @@ project(':connect:transforms') {

dependencies {
implementation project(':connect:api')
implementation project(':clients')
implementation libs.slf4jApi

testImplementation libs.easymock
Expand Down Expand Up @@ -1777,6 +1786,7 @@ project(':connect:runtime') {
implementation project(':connect:transforms')

implementation libs.slf4jApi
implementation libs.slf4jlog4j
implementation libs.jacksonJaxrsJsonProvider
implementation libs.jerseyContainerServlet
implementation libs.jerseyHk2
Expand All @@ -1800,6 +1810,7 @@ project(':connect:runtime') {
testImplementation project(':clients').sourceSets.test.output
testImplementation project(':core')
testImplementation project(':core').sourceSets.test.output
testImplementation libs.scalaLibrary

testRuntimeOnly libs.slf4jlog4j
}
Expand Down Expand Up @@ -1874,6 +1885,7 @@ project(':connect:file') {

dependencies {
implementation project(':connect:api')
implementation project(':clients')
implementation libs.slf4jApi

testImplementation libs.easymock
Expand Down Expand Up @@ -1912,7 +1924,9 @@ project(':connect:basic-auth-extension') {

dependencies {
implementation project(':connect:api')
implementation project(':clients')
implementation libs.slf4jApi
implementation libs.jaxrsApi

testImplementation libs.bcpkix
testImplementation libs.easymock
Expand Down Expand Up @@ -1957,6 +1971,7 @@ project(':connect:mirror') {
implementation project(':clients')
implementation libs.argparse4j
implementation libs.slf4jApi
implementation libs.jacksonDatabind

testImplementation libs.junit
testImplementation libs.mockitoCore
Expand Down

0 comments on commit 514a722

Please sign in to comment.