Add tests that use the FlameGraph test files #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main functionality of collapse-perf has been split out into a library to allow the tests to call handle_file() directly and get a result without creating temporary files. Flamegraph has been added as a git submodule so we can use their test files in flamegraph/test. Not all tests are passing so those still need to be looked into.
jonhoo
reviewed
Jan 29, 2019
jonhoo
reviewed
Jan 29, 2019
jonhoo
reviewed
Jan 29, 2019
|
This is so great! See the inline comments I've left. Can you give me some insight into which tests/patterns are failing? |
This was referenced Jan 29, 2019
Closed
Sometimes the stack line has 2 spaces after the pc like this:
7f1e2215d058 (/lib/x86_64-linux-gnu/libc-2.15.so)
The perl version preserves the extra space as the func. This commit
matches that behavior, which makes 5 more tests pass.
|
5 more tests pass with 07c27d7. |
|
Thanks! I'll start integrating this with CI and do some clean-up, but this is a superb starting point! |
|
I believe I've fixed the remaining tests now. CI is running it here as we speak! |
This was referenced Jan 29, 2019
jonhoo
pushed a commit
that referenced
this pull request
Sep 9, 2023
Put 1.70 in there (for instance if you want to pin against OnceLock stabilizing) and it will actually test 1.7 as it appears github auto converts this to a float? Putting in quotes seems to do the right thing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main functionality of collapse-perf has been split out into a library to
allow the tests to call handle_file() directly and get a result without
creating temporary files.
Flamegraph has been added as a git submodule so we can use their test files in
flamegraph/test. Not all tests are passing so those still need to be looked
into.