-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement --factor option #65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 77.54% 77.59% +0.04%
==========================================
Files 15 13 -2
Lines 1287 1263 -24
==========================================
- Hits 998 980 -18
+ Misses 289 283 -6
Continue to review full report at Codecov.
|
Looks good beyond my comment in #19 (comment). Specifically, I think it's not actually okay for us to round and truncate the result to an integer -- it may be fractional after multiplying by the factor. |
Thinking some more, I think we specifically want |
Using
If we round we get If we didn't care about thousands separators we could just format it the same way as the Perl version. |
Wow, that's bizarre. Is that the case in Rust too? That makes no sense to me. But then yes, I think |
Rust formats exactly the same way when using |
Sounds good! I wonder where that behavior comes from... |
🎉 ❤️ |
Implements #19 with a difference from the Perl implementation in how sample counts get rounded, as explained in my comment on that issue. We need to decide if this is acceptable or not.
I've also combined all of the flamegraph tests into one file since they all duplicated the main testing code.