Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Openssl for Windows #12

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

chapeupreto
Copy link
Contributor

This PR adds OpenSSL for Windows as seen here: https://youtu.be/xUH-4y92jPg?t=3601

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice, thanks!

@jonhoo jonhoo merged commit c704bcc into jonhoo:main Aug 20, 2023
1 of 19 checks passed
@jonhoo
Copy link
Owner

jonhoo commented Aug 20, 2023

I'm actually going to comment this code out, because installing OpenSSL on Windows is quite slow, and for projects that don't need it, that extra 5-10m of CI time isn't worth it.

@chapeupreto chapeupreto deleted the openssl-windows branch August 20, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants