Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear sidebar tree navigator with unopened folders #63

Closed
hmartos opened this issue Sep 29, 2015 · 3 comments
Closed

Clear sidebar tree navigator with unopened folders #63

hmartos opened this issue Sep 29, 2015 · 3 comments

Comments

@hmartos
Copy link
Contributor

hmartos commented Sep 29, 2015

Hello, I know this bug is marked as closed, but I have noticed that it is only working when you click on a folder that have at least one subfolder.

If you click on a folder that have subfolders then tree navigator opens the folder structure, and if you click on another folder that have subfolders the unused folder structure is closed and the new folder structure is opened properly, but if you click on a folder that do not have any subfolder then the unused folder structure is not closed.

image

image

image

I have noticed also that the order of the folders shown in sidebar tree navigation is not the same shown in main-table, I have solved this by sorting nodes in lowercase, inside filenavigator -> buildTree

parent.nodes = parent.nodes.sort(function(a, b) {
    return a.name.toLowerCase() < b.name.toLowerCase() ? -1 : a.name.toLowerCase() === b.name.toLowerCase() ? 0 : 1;
});

Thank you for your time!.

@joni2back
Copy link
Owner

Hello @hmartos yes I'm aware of this bug, and others like renaming folders etc in the sidebar. I want to fix them all doing a refactory in the buildTree method.

Also I saw the same behaviour in the sort of the folder. Would be great if you want to create a pull request with this fix, in order to collaborate in this project !! 😄

hmartos added a commit to hmartos/angular-filemanager that referenced this issue Sep 30, 2015
…i2back#63

Sort order in sidebar is now the same as in main-table. Added name
comparison in lowercase in method buildTree of the service filenavigator
@hmartos
Copy link
Contributor Author

hmartos commented Sep 30, 2015

It is my first pull request, so tell me if I have done something wrong! Thank you very much!

joni2back added a commit that referenced this issue Sep 30, 2015
Related issue: Sort tree like right-content #63
@joni2back
Copy link
Owner

🆗 Done sidebar sort
⌚ pending sidebar item updates (same with #9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants