Skip to content

Conversation

@hmartos
Copy link
Contributor

@hmartos hmartos commented Oct 1, 2015

The filter in main-table was filtering in the hole item object, making some strange behaviours when filtering words like 'dir' or 'false', now it filters only by item.model.name field

@joni2back
Copy link
Owner

Great !!
To merge this pull request you need to discard the changes to the php folder (bridges/php/php-classic)
Also, should be great if you compile the javascript with the gulp task (dist/angular-filemanager.min.js)

Example:

jonas@:~/www/angular-filemanager$: npm install #(install dependencies to execute gulp)
jonas@:~/www/angular-filemanager$: gulp build  #(generate the js in dist folder)

@hmartos
Copy link
Contributor Author

hmartos commented Oct 1, 2015

Ok!, I am going!

@hmartos
Copy link
Contributor Author

hmartos commented Oct 1, 2015

I have errors when doing gulp build "Expected linebreaks to be 'LF' but found 'CRLF'" I think this line break differences between operating systems (I am using Windows). I am very new on this so make me know if there is any other problem. Thank you for your time!

joni2back added a commit that referenced this pull request Oct 1, 2015
Filtering in main-table does not work properly
@joni2back joni2back merged commit f28bc32 into joni2back:master Oct 1, 2015
@joni2back
Copy link
Owner

Yes, is the difference in the line break between windows and linux (\r\n vs \n)
Merge was done, I had to fix the php-classic submodule in a new commit. but is ok.
Thanks!!

@hmartos
Copy link
Contributor Author

hmartos commented Oct 1, 2015

Thank you @joni2back! Awesome project!

@joni2back
Copy link
Owner

Thank you too.
PD: If you want to collaborate in any other feature addition or bugfix, you are welcome!
(there are a known bug in the sidebar, maybe you are the ideal dev to fix this #63)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants