Updated socket-raw required version to stable #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using an updated dependency is a good improvement, but it seem that there are still some conflicts. You're using short array syntax while this library is still supported by PHP 5.3. I haven't done a review of your code, so I'm not sure if there are other reasons for conflicts. I don't see a reason why it shouldn't support 5.6 as minimal version and of course PHP 7. |
Closed
|
@sbattistin Could you please rebase your branch to the latest changes? The project is moving forward again. |
|
Thank you for pointing out the need to update the socket-raw dependency, otherwise it would still be on an old version 👍. This PR can now be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated socket-raw required version to a more stable one. From 1.0 up to non-breaking.