Problems on Windows

[adam-lynch]

On Windows, the basic example only strips the <style> & <link> but does nothing else.

[jonkemp]

Seems like it's a known issue.

andrewrk/juice#4

[adam-lynch]

I commented on Automattic/juice#35.

Are you depending on the fork though? How come?

[jonkemp]

#1

Looks like the owner/maintainer has changed though. It was LearnBoost previously and it was not being actively maintained. Looks like it still has a lot of open issues though.

[adam-lynch]

Hmm ok.

[adam-lynch]

What does closing this issue mean for Windows support? Should it be added to the readme that Windows currently doesn't work?

[jonkemp]

I can't support Windows if juice does not and it looks like neither version does. I have no idea if they plan to support it or not. I'll re-open this and leave it open if it helps.

If you want to add to the documentation, I'm happy to accept pull requests.

[jonkemp]

There's also a few other gulp plugins that can inline css for you.

http://gulpjs.com/plugins/

[adam-lynch]

Yeah, I think reopening this would be best. I can submit a PR to link to it from the readme. FYI can't see any other viable option there. I'd be happy if there was even a plain node module around that did it but I can't seem to find anything that suits which doesn't depend on Juice.

[jonkemp]

gulp-premailer looks nice but it does depend on premailer which is a ruby gem.

https://github.com/justin713/gulp-premailer

[adam-lynch]

Yeah that's the problem. I don't use SASS / Jekyll for the same reason.

[jonkemp]

Version 2.0 does not use jsdom. I've checked it out and run the tests on Windows 7, so I'm pretty confident it works on Windows now. Closing.

[adam-lynch]

Nice

On Tue, 27 Jan 2015 04:31 Jonathan Kemp notifications@github.com wrote:

Version 2.0 does not use jsdom. I've checked it out and run the tests on
Windows 7, so I'm pretty confident it works on Windows now. Closing.

—
Reply to this email directly or view it on GitHub
#8 (comment)
.