Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up version numbering. #95

Merged
merged 1 commit into from
Jan 4, 2016
Merged

Tidy up version numbering. #95

merged 1 commit into from
Jan 4, 2016

Conversation

jonm
Copy link
Owner

@jonm jonm commented Jan 2, 2016

We (ok, I) have been doing git tags for releases like "v0.1.9"
but this results in the use of that version string downstream.
For example, make dist will produce sillymud-v0.1.9.tar.gz
instead of the desired sillymud-0.1.9.tar.gz. This change
just strips the leading v off the tag name to use for the
autotools version.

However, I would also be ok with going back through to update
the git tags to be the version numbers we want (0.1.9) under
the assumption that probably no one would care. Putting this
PR to collect opinions on the best path forward.

@dangitall
Copy link
Collaborator

I have no strong preference in either direction. I've always use a leading 'v' so it just looks right to me, but that's no reason to go on with that.

One reason a leading v is helpful, though, is that the git describe should probably look more like git describe --match 'v*' to make sure (well, just be more confident really, it isn't foolproof certainly) we only grab version tags. That is harder if you just use the bare version, I'm not sure the glob syntax is expressive enough.

We (ok, I) have been doing git tags for releases like "v0.1.9"
but this results in the use of that version string downstream.
For example, `make dist` will produce `sillymud-v0.1.9.tar.gz`
instead of the desired `sillymud-0.1.9.tar.gz`. This change
just strips the leading `v` off the tag name to use for the
_autotools_ version.

However, I would also be ok with going back through to update
the git tags to be the version numbers we want (`0.1.9`) under
the assumption that probably no one would care. Putting this
PR to collect opinions on the best path forward.
jonm added a commit that referenced this pull request Jan 4, 2016
@jonm jonm merged commit a566231 into master Jan 4, 2016
@jonm jonm deleted the version-number branch January 4, 2016 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants