Clean backend name if beginning with reload_ #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 16, 2019 14:36
The varnish_reload_vcl script as shipped with Varnish 4 packages uses one format, and varnishreload shipped with 6+ packages uses a slightly different. This covers both.
|
Looks good, thanks! |
|
Your PR is included in the 1.5.2 release, thanks for your contribution. |
|
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using often-shipped scripts to reload varnish VCLs, the backend names changes from "boot" to reload_xxxxx.
Initially, metrics would be exported with
default, then after one reload it would bereload_20191016_072034_54500.default.The varnish_reload_vcl script as shipped with Varnish 4 packages uses one format,
and varnishreload shipped with 6+ packages uses a slightly different.
This covers both.
Note: this is my very first attempt on Go coding, so feel free to point out improvements!