Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"non_primary_companies" is deprecated #7

Closed
imod opened this issue Jul 1, 2014 · 1 comment
Closed

"non_primary_companies" is deprecated #7

imod opened this issue Jul 1, 2014 · 1 comment

Comments

@imod
Copy link
Contributor

imod commented Jul 1, 2014

The current implementation calls for "non_primary_companies", but this field is deprecated.
In fact, the response contains the following payload:

...
"non_primary_companies":[{"_this_is_deprecated_since":"2014-05-08"
...

This should be replaced with "companies". The file 'full_profile.json' in the test cases already only contains the new field (so its easy to add a test case). I think this should be removed/switched in the interface before to many people depend on it.
imod added a commit to imod/spring-social-xing that referenced this issue Aug 7, 2014
@imod
mark "non_primary_companies" as deprecated (deprecated by sing since …
222070f 
…"2014-05-08") and introduce "companies" (fixes GH issue jonnybbb#7)
@imod
Copy link
Contributor Author

imod commented Sep 22, 2014

implemented since 1.1.1.RELEASE

@imod imod closed this as completed Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imod