New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/trim dependencies #424
Conversation
I sound like a broken record, but this awesome and super appreciative to have another set of eyes on this codebase! Thanks! |
I'm getting errors when running |
Which branch are you running it in? It doesn't look like |
It's in the Input_0:15593 (JSC_PARSE_ERROR)
Parse error. illegal use of unknown JSDoc tag "nota"; ignoring it Because there are Now that we're talking about it, though. In your ES6 PR you changed the compiler so maybe this isn't a huge issue. |
Sorry about that. Indeed, it looks like the latest version of Closure Compiler tries to parse JSDoc comments, but errors out if it considers them invalid. There's a way to add custom JSDoc annotation names in Closure Compiler itself, but node-minify doesn't expose the flag. |
Amazing, should be straightforward to amend the build script to add those terms. I can do that. Thanks for the info! |
Update/trim dependencies
I've split this PR into 5 commits:
Update QUnit
qunitjs
toqunit
. I've updated this where necessary.Update resemble.js
Remove moment.js
Date
object'stoISOString
method.Remove animation-frame, blueimp-canvas-to-blob, jsdoc-to-markdown
Update node-minify