Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/trim dependencies #424

Merged
merged 5 commits into from Dec 8, 2019
Merged

Update/trim dependencies #424

merged 5 commits into from Dec 8, 2019

Conversation

adroitwhiz
Copy link
Contributor

I've split this PR into 5 commits:

  • Update QUnit

    • QUnit changed the name of their package from qunitjs to qunit. I've updated this where necessary.
  • Update resemble.js

    • While it's undergone 2 major version bumps, tests which use it still seem to run properly.
  • Remove moment.js

    • Moment.js was only used for formatting the publish date in the build process. I've replaced it with the Date object's toISOString method.
    • As a result, publish date timestamps will now be in UTC rather than the local timezone of the machine that the build was run on.
  • Remove animation-frame, blueimp-canvas-to-blob, jsdoc-to-markdown

    • These dependencies appear to have been previously used for testing, but are no longer used.
  • Update node-minify

@jonobr1
Copy link
Owner

jonobr1 commented Dec 8, 2019

I sound like a broken record, but this awesome and super appreciative to have another set of eyes on this codebase! Thanks!

@jonobr1 jonobr1 merged commit 0645b67 into jonobr1:dev Dec 8, 2019
@jonobr1
Copy link
Owner

jonobr1 commented Dec 9, 2019

I'm getting errors when running node ./utils/build because I have custom jsdocs comments @nota-bene. Did you get these as well? If so how did you work around this to

@adroitwhiz
Copy link
Contributor Author

Which branch are you running it in? It doesn't look like utils/build is doing anything JSDoc-related in dev.

@jonobr1
Copy link
Owner

jonobr1 commented Dec 9, 2019

It's in the dev branch. I'm getting these parse errors with the latest closure compiler modules:

Input_0:15593 (JSC_PARSE_ERROR)

Parse error. illegal use of unknown JSDoc tag "nota"; ignoring it

Because there are @nota-bene custom jsdocs symbols added for inline documentation.

Now that we're talking about it, though. In your ES6 PR you changed the compiler so maybe this isn't a huge issue.

@adroitwhiz
Copy link
Contributor Author

Sorry about that. Indeed, it looks like the latest version of Closure Compiler tries to parse JSDoc comments, but errors out if it considers them invalid.

There's a way to add custom JSDoc annotation names in Closure Compiler itself, but node-minify doesn't expose the flag.

@jonobr1
Copy link
Owner

jonobr1 commented Dec 9, 2019

Amazing, should be straightforward to amend the build script to add those terms. I can do that. Thanks for the info!

elShiaLabeouf pushed a commit to elShiaLabeouf/two.js that referenced this pull request Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants