Skip to content
This repository has been archived by the owner on Aug 15, 2021. It is now read-only.

Validation with fields filled in with password managers. #148

Open
blakbarn opened this issue Jul 5, 2016 · 3 comments
Open

Validation with fields filled in with password managers. #148

blakbarn opened this issue Jul 5, 2016 · 3 comments

Comments

@blakbarn
Copy link

blakbarn commented Jul 5, 2016

We have had several people complain because when they use password managers to fill in their username and password it will not update the model so the validation fails. Basically the model does not get updated in this case. They have to copy and paste the username and password manually. I know there is a bug is some browsers that does not properly set the event for updating the model when this happens.

If there was a way to check to see if the model and the value of the element are out of sync before validation then this could be fixed before validation occurs. I happen to be using the KeepPass extention for Chrome.

@jonsamwell
Copy link
Owner

Works fine for me in chrome. Feel free to send in a PR or do a reproducing
plunker so I can debug

On 09:26, Wed, 6 Jul 2016 blakbarn, notifications@github.com wrote:

We have had several people complain because when they use password
managers to fill in their username and password it will not update the
model so the validation fails. Basically the model does not get updated in
this case. They have to copy and paste the username and password manually.
I know there is a bug is some browsers that does not properly set the event
for updating the model when this happens.

If there was a way to check to see if the model and the value of the
element are out of sync before validation then this could be fixed before
validation occurs. I happen to be using the KeepPass extention for Chrome.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#148, or mute
the thread
https://github.com/notifications/unsubscribe/ADhfoVQsq7EPeiniKsU5mVqOyb4l5QBtks5qSug-gaJpZM4JFn9o
.

@blakbarn
Copy link
Author

blakbarn commented Jul 5, 2016

Did you try it with the KeePass extension or the built in Chrome password
manager. The built in one works fine for me it is just ones like KeePass
the populate the field with javascript. They do not trigger the event to
update the model. I will see if I can create a quick plunker tomorrow.

Blake Barnett
Lead Web Developer

509.336.4434
blakbarn@selinc.com ? www.selinc.com

From: Jon Samwell notifications@github.com
To: jonsamwell/angular-auto-validate
angular-auto-validate@noreply.github.com
Cc: blakbarn blakbarn@selinc.com, Author author@noreply.github.com
Date: 07/05/2016 04:51 PM
Subject: Re: [jonsamwell/angular-auto-validate] Validation with
fields filled in with password managers. (#148)

Works fine for me in chrome. Feel free to send in a PR or do a reproducing
plunker so I can debug

On 09:26, Wed, 6 Jul 2016 blakbarn, notifications@github.com wrote:

We have had several people complain because when they use password
managers to fill in their username and password it will not update the
model so the validation fails. Basically the model does not get updated
in
this case. They have to copy and paste the username and password
manually.
I know there is a bug is some browsers that does not properly set the
event
for updating the model when this happens.

If there was a way to check to see if the model and the value of the
element are out of sync before validation then this could be fixed
before
validation occurs. I happen to be using the KeepPass extention for
Chrome.

?
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#148, or
mute
the thread
<
https://github.com/notifications/unsubscribe/ADhfoVQsq7EPeiniKsU5mVqOyb4l5QBtks5qSug-gaJpZM4JFn9o

.

?
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub[github.com], or mute the
thread[github.com].

@jonsamwell
Copy link
Owner

No just chrome. I would fill a bug report with the extension then as the
library is working as it should and the extension is most likely not
working correctly

On Wed, 6 Jul 2016 at 09:58 blakbarn notifications@github.com wrote:

Did you try it with the KeePass extension or the built in Chrome password
manager. The built in one works fine for me it is just ones like KeePass
the populate the field with javascript. They do not trigger the event to
update the model. I will see if I can create a quick plunker tomorrow.

Blake Barnett
Lead Web Developer

509.336.4434
blakbarn@selinc.com ? www.selinc.com

From: Jon Samwell notifications@github.com
To: jonsamwell/angular-auto-validate
angular-auto-validate@noreply.github.com
Cc: blakbarn blakbarn@selinc.com, Author author@noreply.github.com
Date: 07/05/2016 04:51 PM
Subject: Re: [jonsamwell/angular-auto-validate] Validation with
fields filled in with password managers. (#148)

Works fine for me in chrome. Feel free to send in a PR or do a reproducing
plunker so I can debug

On 09:26, Wed, 6 Jul 2016 blakbarn, notifications@github.com wrote:

We have had several people complain because when they use password
managers to fill in their username and password it will not update the
model so the validation fails. Basically the model does not get updated
in
this case. They have to copy and paste the username and password
manually.
I know there is a bug is some browsers that does not properly set the
event
for updating the model when this happens.

If there was a way to check to see if the model and the value of the
element are out of sync before validation then this could be fixed
before
validation occurs. I happen to be using the KeepPass extention for
Chrome.

?
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#148, or
mute
the thread
<

https://github.com/notifications/unsubscribe/ADhfoVQsq7EPeiniKsU5mVqOyb4l5QBtks5qSug-gaJpZM4JFn9o

.

?
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub[github.com], or mute the
thread[github.com].


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#148 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADhfoYzIF7BvxIgwMEeyZVHZQaix7VnZks5qSu-KgaJpZM4JFn9o
.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants