Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Released! Make announces in appropriate places! #34

Closed
puzrin opened this issue Oct 16, 2014 · 11 comments
Closed

Released! Make announces in appropriate places! #34

puzrin opened this issue Oct 16, 2014 · 11 comments

Comments

@puzrin
Copy link
Contributor

puzrin commented Oct 16, 2014

Time to buzz :)

This ticket is a notification for all who tracked development progress. Will be closed after 1-2 weeks.

@jonschlinkert
Copy link
Owner

👍 awesome

@puzrin
Copy link
Contributor Author

puzrin commented Oct 16, 2014

@jonschlinkert please update project description (words "This project is not ready to install and use." )

Also, if you have time - check grammar in readme & package.json description

@jonschlinkert
Copy link
Owner

I'm going to pull down the latest now and do this. Also, I'd like to improve the styles used on the demo, if you want I can create a branch for it so you can review first.

@jonschlinkert
Copy link
Owner

This is 100% commonmark compliant, correct?

@jonschlinkert
Copy link
Owner

e.g. I know that's inferred everywhere, but not explicitly stated

@puzrin
Copy link
Contributor Author

puzrin commented Oct 16, 2014

This is 100% commonmark compliant, correct?

https://github.com/jonschlinkert/remarkable#usage see last example.

You can make it 100% comliant with half of line :) . Here is code doing that.

In real life it's a bit useless for web, so defaults are different (extentions are enabled, html disabled, html output instead of xthml)

@jonschlinkert
Copy link
Owner

Ha, I just now read that line. I know we're releasing right now, but I just noticed this:

You can also reset parser to strict [CommonMark](http://commonmark.org/) mode:
```js
var Remarkable = require('remarkable');
var md = new Remarkable('commonmark');
```

I think commonmark should be an option like all the others. This seems strange.

@puzrin
Copy link
Contributor Author

puzrin commented Oct 16, 2014

This mode is not "compatible" with other flags. It's done just for fun. I doubt if anyone use it. Having as object property will be confusing.

Let's wait. If anyone can explain, why it's really needed - we can change in next releases. But now i'd prefere to leave as is.

@jonschlinkert
Copy link
Owner

Ok, no prob

@puzrin
Copy link
Contributor Author

puzrin commented Oct 22, 2014

1.1.1 removed all pending shit from inlines internals. I don't expect major changes anymore. Other core changes can be done after collecting users feedback.

@rayshan
Copy link

rayshan commented Oct 27, 2014

HN post was pretty popular: https://news.ycombinator.com/item?id=8510122. I think generally there's a lot of demand for an actively developed JavaScript markdown parser, and you guys are doing a great job!

@puzrin puzrin closed this as completed Nov 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants