Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm test command #75

Merged
merged 1 commit into from Oct 28, 2014
Merged

Add npm test command #75

merged 1 commit into from Oct 28, 2014

Conversation

denis-sokolov
Copy link
Contributor

It's a good common courtesy to allow people to git clone; npm install; npm test without trying to guess how repo internals are set up.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cfa4cc1 on denis-sokolov:test-script into 96a65ba on jonschlinkert:dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cfa4cc1 on denis-sokolov:test-script into 96a65ba on jonschlinkert:dev.

@puzrin
Copy link
Contributor

puzrin commented Oct 28, 2014

It's only partial solution. Is it urgent? We not yet started polishing for "regular users". Probably all make targets need to be replaced with gulp and so on.

@denis-sokolov
Copy link
Contributor Author

There's nothing wrong with make per se.

The only one make target you have that common contributors may be interested in is, well, the test runner. You want your contributors to not need to worry how to run your tests, because their interest may quickly pass.

Adding this is safe and compatible, and if you change your task runner later, you'll change the package.json as well.

puzrin pushed a commit that referenced this pull request Oct 28, 2014
@puzrin puzrin merged commit a76a5c8 into jonschlinkert:dev Oct 28, 2014
@denis-sokolov denis-sokolov deleted the test-script branch October 28, 2014 08:34
@puzrin
Copy link
Contributor

puzrin commented Oct 28, 2014

Ok. Nobody suggested me such things before in other projects, but if you think that it helps - no prob.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants