Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS #7

Open
yaron2 opened this issue Nov 2, 2019 · 2 comments
Open

TLS #7

yaron2 opened this issue Nov 2, 2019 · 2 comments

Comments

@yaron2
Copy link

yaron2 commented Nov 2, 2019

How can a TLS connection be enabled with redispipe?

@funny-falcon-at-joomcode
Copy link
Contributor

Currently there is no option. We are using opensource redis, and it doesn't have TLS. Therefore, we had no need to implement it.

Connection logic is concentrated in conn.dial function:

func (conn *Connection) dial() error {

redispipe/redisconn/conn.go

Lines 525 to 528 in b212f1f

connection, err = dialer.DialContext(conn.ctx, network, address)
if err != nil {
return conn.errWrap(ErrDial, err)
}

I will accept well formatted PR if you send one.
It will be great if PR will contain instructions to test it, since I hardly know how to run Redis through TLS at the moment.

@funny-falcon
Copy link
Contributor

Looks like it is fixed in #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants