Support TLS #24
Merged
Support TLS #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aglarendil
force-pushed
the
feature/tls-support
branch
2 times, most recently
from
09c8ae1 to
bdb8917
Compare
Allow to pass TLSEnabled bool and TLSConfig struct to opts thus effectively enabling TLS Support.
1. We do not need redis from joomcode as all the patches have been merged upstream already 2. Install libssl-dev and set BUILD_TLS build var
1. allow to init a rediscluster with TLS options 2. pass env variable for 2 variants of tests: with and w/o TLS
aglarendil
force-pushed
the
feature/tls-support
branch
from
41000d1 to
1065256
Compare
marusama
requested changes
Feb 28, 2023
marusama
approved these changes
Feb 28, 2023
g7r
approved these changes
Mar 2, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pass TLSEnabled bool and TLSConfig struct to opts thus effectively enabling TLS Support.