Implementing full associations for single weblink #349

infograf768 · 2017-05-16T06:46:20Z

@zero-24
to be checked for unvoluntary modifications of already merged PRs

@astridx Please test

infograf768 · 2017-05-16T07:06:17Z

Note: this includes and replaces #336 and #346

astridx · 2017-05-16T09:28:57Z

@infograf768 Thank you very much.
I had a first test and noticed two things.
The files in the folder media are not copied with the installation. I think we have to add an entry in the manifest file.
And I would name the entry in the select box for the associations in the singular not in the plural.
Edit: My first opinion was, because I want to edit only one web link. But I see many web links in the list, so the plural is OK. But we mixed singular and plural in this select box - contact is in singular.

This evening I will have a closer look.

astridx · 2017-05-16T10:35:09Z

src/administrator/components/com_weblinks/models/weblink.php

@@ -200,6 +210,25 @@ public function getItem($pk = null)
 			$registry->loadString($item->images);
 			$item->images = $registry->toArray();

+			// Load associated newsfeeds items


Change newsfeeds to weblinks?

astridx · 2017-05-16T11:45:15Z

src/media/com_weblinks/js/admin-weblinks-modal.min.js

@@ -0,0 +1,61 @@
+/**


Should we minimize this file?

infograf768 · 2017-05-16T11:49:13Z

on ipad now. will look later. :)

infograf768 · 2017-05-16T16:06:48Z

But we mixed singular and plural n this select box - contact is in singular.

Yep, that's the only one. It was a mistake when we merged com_associations.
We have to propose a patch on cms changing
"COM_CONTACT_CONTACTS="Contact"
to
COM_CONTACT_CONTACTS="Contacts"
in
administrator/language/en-GB/en-GB.com_contact.ini

infograf768 · 2017-05-16T16:18:52Z

Should we minimize this file?

I added the call into the manifest but not sure we need them.
I picked the one you posted in your PR and I see
// Used in xtd_contacts

Even if that is a typo, we do not have an xtd-weblinks and I do not know if we need these js at all. For example, we do not have these js for newsfeeds.

That type of js was introduced in joomla/joomla-cms#12561 and then modified.

Calling @dgt41 to look into that.

astridx · 2017-05-16T18:43:25Z

src/administrator/components/com_weblinks/views/weblinks/tmpl/modal.php

+JHtml::addIncludePath(JPATH_COMPONENT . '/helpers/html');
+JHtml::_('behavior.core');
+JHtml::_('behavior.polyfill', array('event'), 'lt IE 9');
+JHtml::_('script', 'com_weblinks/admin-weblinks-modal.js', array('version' => 'auto', 'relative' => true));


We need the admin-weblinks-modal.js (currently we use not the min) because we use it here. If we not have this Javascript, it is not possible to select an item when creating a menu item for the single view.

dgrammatiko · 2017-05-16T20:19:07Z

Even if that is a typo, we do not have an xtd-weblinks and I do not know if we need these js at all. For example, we do not have these js for newsfeeds.

Actually there should be a button for every type of content in Joomla (newsfeed, weblink, etc)

infograf768 · 2017-05-17T06:13:36Z

OK. Will add the xtd-editor for weblinks and minimise js

infograf768 · 2017-05-17T07:10:25Z

I guess we should be OK now.

@zero-24
Please check my changes in pkg_weblinks.xml where I added the new plugin

infograf768 · 2017-05-17T07:49:24Z

Results should now be:

astridx · 2017-05-19T17:02:23Z

For me, almost everything works. I have only problems with the xtd plugin. But I think it's up to me. I'll try again tomorrow.
I only suggest to call the plugin weblinks (plural - not weblink (singular)), because we call all other plugins synonymous.

astridx · 2017-05-19T17:16:41Z

src/administrator/language/en-GB/en-GB.com_weblinks.ini

@@ -116,9 +118,11 @@ COM_WEBLINKS_ORDER_HEADING="Order"
 COM_WEBLINKS_RIGHT="Right"
 COM_WEBLINKS_SAVE_SUCCESS="Web link successfully saved"
 COM_WEBLINKS_SEARCH_IN_TITLE="Search in title"
+COM_WEBLINKS_SELECT_A_WEBLINK="Select Weblink"


Shall we use "Web link" everywhere and not "Weblink"?

yep. will do
Web Link maybe. will look elsewhere.
or web link in this phrase

astridx · 2017-05-19T17:45:36Z

src/plugins/editors-xtd/weblink/weblink.php

+defined('_JEXEC') or die;
+
+/**
+ * Editor WEb Link button


Web for WEb

infograf768 · 2017-05-19T18:52:06Z

concerning name of plugin, except for fields, they are singular
PLG_ARTICLE_BUTTON_ARTICLE="Article"

https://github.com/joomla/joomla-cms/tree/staging/plugins/editors-xtd

infograf768 · 2017-05-20T06:29:52Z

@astridx
Corrections done.

astridx · 2017-05-20T08:58:17Z

I have tested this PR successfully.
I created an weblink item and translated it into the associations-component. Then I created several weblinks items in several languages and linked (associated) them in the weblinks components to another language.
Die frontend view was OK
I created a xtd-button and inserted an weblink with the help of this button into an article.

Concerning name of plugin: I meant, that the names of all other weblink plugins (finder, system, search) are in singular. But that was only a suggestion.
And I had another idea while I tested. Should we add the images to the single frontend view? At the moment we use this only for the category view. But this is only a suggestion, too. We can do this in another PR later. If you like I would open an issue for this.

infograf768 · 2017-05-20T11:30:10Z

Concerning name of plugin: I meant, that the names all other weblink plugins (finder, system, search) are in singular. But that was only a suggestion.

we have to normaise vs editors-xtd plugins, not any other type. 😃

infograf768 · 2017-05-22T08:27:13Z

@zero-24
OK to merge?

fix some smal things

zero-24 · 2017-05-22T12:16:40Z

looks ok now from a quick review but I did not found time to test this yet. Sorry.

astridx · 2017-06-07T21:23:37Z

I just noticed something. If an weblink is unpulished, you can see it in this single weblink view, if you know the link. This a security problem, right?

zero-24 · 2017-06-07T21:44:50Z

I guess we need to debug this here: https://github.com/joomla-extensions/weblinks/blob/master/src/components/com_weblinks/models/weblink.php#L73-L83

infograf768 · 2017-06-09T09:41:04Z

btw, folks, we are freezing languages for the CMS on the 13th.
These new strings should added to core before that date. Thanks.

infograf768 · 2017-06-09T12:42:06Z

If an weblink is unpulished, you can see it in this single weblink view, if you know the link.

It should throw a 404 when a single weblink menu item is clicked.
Looking into that now.

infograf768 · 2017-06-10T06:36:27Z

@zero-24 @dgt41 @astridx

I have now updated the frontend model for weblink. It should now take care of language, access, state.

Please test and check code.

ghost · 2017-09-14T06:18:20Z

this PR is ready for Test?

infograf768 · 2017-09-14T07:05:14Z

It was, last time I tested. :) In June.

ghost · 2017-09-14T07:51:29Z

can there be proper Test Instructions at first Comment?

As far as i read there should be a "single weblink" (menue?) which i can't find, also no Button so i share Comments of @infograf768 in #346 why to have multlingual as you got to an Page after click on Weblink.

infograf768 · 2017-09-14T08:01:57Z

as far as I remember, there is a already a single weblink menu item and with this patch instead of displaying directly the page targeted by this link, it displays a joomla frontend page containing the web link to click on, therefore permitting associations.

astridx · 2017-09-14T08:04:33Z

why to have multlingual as you got to an Page after click on Weblink.

You are right. The single view and the multilingual is not really neccessary for this component. But I think weblinks is a component where others (and I) have the opportunity to learn creating componentens.

As far as i read there should be a "single weblink"

Do I understand you right? You do not see the opportunity to create a single weblink view when you create a menu point? It should be similar to com_content, where you can create a menu item for a single article.

ghost · 2017-09-14T08:28:00Z

correct, no "Single Weblink"-Menu Item:

Test on

weblinks-3.7.0-beta1
macOS Sierra, 10.12.5
Firefox 55.0 (64-bit)

MAMP 4.1.1

PHP 7.0.15
MySQLi 5.6.35

astridx · 2017-09-16T17:29:09Z

I applied the path via Patch Tester and @franz-wohlkoenig is right, here I saw no menu item for a single web link. By the way, there was no JOOMLA/components/com_weblinks/views/weblink/tmpl/default.xml file in the folder. I think patch tester can not copy new files. And this file is new in this version.

Then I applied the branch via git fetch upstream pull/349/head:weblinks_assoc and built a new pkg-weblinks-current.zip and installed this.

After that I could create a new menu item. I saw the web link in the front end, when I clicked it. After publishing these web link I saw a 404 error.

I could create web links and web links categories for other languages via multilingual component. And I saw the association tab in the web links component and I could use it.

I made some checks on a website, that is not multilingual and there was everything OK, I mean, I saw no association tab.

I had only one issue. I could not create a web link with the same alias in different languages. But I would like to merge this and open an issue for the opportunity to have the same alias for different languages.

I tested with Joomla! 3.8.0-rc2-dev Development [ Amani ] 5-September-2017 14:00 GMT

infograf768 added 2 commits May 16, 2017 08:03

IMplementing full associations

3389bf4

missing change

99f239c

This was referenced May 16, 2017

Frontend view single weblink 2 #336

Closed

Add Support for translating one item via Multilingual Associations #346

Closed

astridx reviewed May 16, 2017

View reviewed changes

src/media/com_weblinks/js/admin-weblinks-modal.min.js Outdated

@@ -0,0 +1,61 @@

/**

Copy link

Contributor

astridx May 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we minimize this file?

infograf768 added 2 commits May 16, 2017 17:50

adding media in manifest

9b6e02a

Changing comment

75684b9

astridx reviewed May 16, 2017

View reviewed changes

infograf768 added 2 commits May 17, 2017 09:06

Minifying js and adding xtd-editors web link

3151bf9

correcting date

4f33935

astridx reviewed May 19, 2017

View reviewed changes

src/plugins/editors-xtd/weblink/weblink.php Outdated

defined('_JEXEC') or die;

/**

* Editor WEb Link button

Copy link

Contributor

astridx May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web for WEb

small corrections

db0bfa9

fix some smal things

9b30ced

infograf768 and others added 4 commits May 22, 2017 12:01

Merge pull request #5 from zero-24/weblinks_assoc

da554cb

fix some smal things

deploy

b6e084a

Update weblink.php

7e9269d

Update modal.php

58fa74a

Correcting weblink frontend model to adapt to the new display

7254648

astridx mentioned this pull request Sep 18, 2017

[RFC] [3.7] Add basic custom fields support #317

Merged

astridx added this to the Weblinks 3.7.1 milestone Nov 3, 2017

astridx merged commit d0ff882 into joomla-extensions:master Nov 3, 2017

This was referenced Nov 3, 2017

I can not create a web link with the same alias in different languages. #371

Closed

Improved the Batch view of com_weblinks #375

Merged

Make tool bar filter fields nice and multiple #377

Closed

infograf768 mentioned this pull request Apr 6, 2018

Create a Menu-Link directly to a WebLinks URL #211

Closed

infograf768 deleted the weblinks_assoc branch December 27, 2019 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing full associations for single weblink #349

Implementing full associations for single weblink #349

infograf768 commented May 16, 2017

infograf768 commented May 16, 2017

astridx commented May 16, 2017 •

edited

astridx May 16, 2017

astridx May 16, 2017

infograf768 commented May 16, 2017

infograf768 commented May 16, 2017

infograf768 commented May 16, 2017

astridx May 16, 2017 •

edited

dgrammatiko commented May 16, 2017

infograf768 commented May 17, 2017

infograf768 commented May 17, 2017

infograf768 commented May 17, 2017

astridx commented May 19, 2017 •

edited

astridx May 19, 2017 •

edited

infograf768 May 19, 2017 •

edited

astridx May 19, 2017

infograf768 commented May 19, 2017

infograf768 commented May 20, 2017

astridx commented May 20, 2017 •

edited

infograf768 commented May 20, 2017 •

edited

infograf768 commented May 22, 2017

zero-24 commented May 22, 2017

astridx commented Jun 7, 2017

zero-24 commented Jun 7, 2017

infograf768 commented Jun 9, 2017

infograf768 commented Jun 9, 2017

infograf768 commented Jun 10, 2017

ghost commented Sep 14, 2017

infograf768 commented Sep 14, 2017

ghost commented Sep 14, 2017

infograf768 commented Sep 14, 2017

astridx commented Sep 14, 2017 •

edited

ghost commented Sep 14, 2017 •

edited by ghost

astridx commented Sep 16, 2017 •

edited

Implementing full associations for single weblink #349

Implementing full associations for single weblink #349

Conversation

infograf768 commented May 16, 2017

infograf768 commented May 16, 2017

astridx commented May 16, 2017 • edited

astridx May 16, 2017

Choose a reason for hiding this comment

astridx May 16, 2017

Choose a reason for hiding this comment

infograf768 commented May 16, 2017

infograf768 commented May 16, 2017

infograf768 commented May 16, 2017

astridx May 16, 2017 • edited

Choose a reason for hiding this comment

dgrammatiko commented May 16, 2017

infograf768 commented May 17, 2017

infograf768 commented May 17, 2017

infograf768 commented May 17, 2017

astridx commented May 19, 2017 • edited

astridx May 19, 2017 • edited

Choose a reason for hiding this comment

infograf768 May 19, 2017 • edited

Choose a reason for hiding this comment

astridx May 19, 2017

Choose a reason for hiding this comment

infograf768 commented May 19, 2017

infograf768 commented May 20, 2017

astridx commented May 20, 2017 • edited

infograf768 commented May 20, 2017 • edited

infograf768 commented May 22, 2017

zero-24 commented May 22, 2017

astridx commented Jun 7, 2017

zero-24 commented Jun 7, 2017

infograf768 commented Jun 9, 2017

infograf768 commented Jun 9, 2017

infograf768 commented Jun 10, 2017

ghost commented Sep 14, 2017

infograf768 commented Sep 14, 2017

ghost commented Sep 14, 2017

infograf768 commented Sep 14, 2017

astridx commented Sep 14, 2017 • edited

ghost commented Sep 14, 2017 • edited by ghost

Test on

MAMP 4.1.1

astridx commented Sep 16, 2017 • edited

astridx commented May 16, 2017 •

edited

astridx May 16, 2017 •

edited

astridx commented May 19, 2017 •

edited

astridx May 19, 2017 •

edited

infograf768 May 19, 2017 •

edited

astridx commented May 20, 2017 •

edited

infograf768 commented May 20, 2017 •

edited

astridx commented Sep 14, 2017 •

edited

ghost commented Sep 14, 2017 •

edited by ghost

astridx commented Sep 16, 2017 •

edited