Container::buildObject may result in infitite loop

[piotr-cz]

The buildObject method uses set method at the bottom.

In specific case this may lead to infinite loop of
Joomla\DI\Container->buildObject() and Joomla\DI\Container->getMethodArgs() methods resulting in
Fatal error: Maximum function nesting level of '100' reached, aborting!

Because same key is being set in two places at a time:

$fqcn = '\\Extension\\vendor\\FooComponent\\FooComponent';
$data = array();

$container->set(
    $fqcn,
    function (Container $c) use ($fqcn, $data)
    {
        $instance = $c->buildObject($fqcn);
        $instance->setData($data);

        return $instance;
    }
);

I'm not sure if this is a bug (I'd say the set method shouldn't be part of the buildObject) or I misunderstood the functionality.

[dongilbert]

Can you send me the code that causes this so I can better debug?

[piotr-cz]

Sure, it's https://github.com/joomContrib/extension/blob/master/src/ExtensionServiceProvider.php#L101

[nibra]

The problem is not caused by the call to set(), but by a circular dependency. $fqcn has to be resolved in order to resolve $fqcn, which leads to an endless loop.

There's no way to get around this; however, buildObject() can be changed to detect that and throw an exception. I solved that already in my repo, PR comes when I'm done with the documentation.

[mbabker]

Fixed via 33c66e4 for 1.x (by backporting appropriate changes from #16).