Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.x needs a tag #28

Closed
Bilge opened this issue Oct 28, 2017 · 12 comments
Closed

Version 2.x needs a tag #28

Bilge opened this issue Oct 28, 2017 · 12 comments

Comments

@Bilge
Copy link
Contributor

Bilge commented Oct 28, 2017

For whatever reason, joomla/di appears in the list of packages providing psr/container-implementation, and yet it does not: this package is not PSR-11 compatible in any way. I honestly have no idea how a package ends up on that list, but if it is under your control, I think it should be removed from that list.

@mbabker
Copy link
Contributor

mbabker commented Oct 28, 2017

The 2.0 branch implements the interface, 1.x does not.

@Bilge
Copy link
Contributor Author

Bilge commented Oct 28, 2017

Oh, I see, but the 2.0 branch isn't tagged yet, right?

@mbabker
Copy link
Contributor

mbabker commented Oct 28, 2017

Right.

@Bilge
Copy link
Contributor Author

Bilge commented Oct 28, 2017

Would it be possible to get a tag so we can start using it now? I note development seems to have slowed down since it hasn't been touched since August. I don't know if that means it's stable enough for a tag yet.

@mbabker
Copy link
Contributor

mbabker commented Oct 28, 2017

Internally I think we still need to come up with a master release plan for the Framework 2.0 packages. In general I think the aim has been to tag those with the CMS 4.0 release next year.

In general though, aside from the Form package, each of the other 2.0 dev branches should be stable enough for use and I don't foresee many other major changes that would cause issues if implementing them now.

@Bilge
Copy link
Contributor Author

Bilge commented Oct 28, 2017

I don't foresee many other major changes that would cause issues if implementing them now.

Being as that's the case, why not just add a stable tag now? I don't use Joomla so I don't know how your releases work typically, but I am interested in a quality, lightweight DI container that's less bloated than what Symfony, Zend, PHP-DI, etc. are offering and this package seems to fit the bill nicely.

@mbabker
Copy link
Contributor

mbabker commented Oct 28, 2017

I'll talk this over with a couple of others and work out a plan. Conceivably we should be safe to start tagging at a minimum betas if not stable for the 2.0 branches, personally I think it's now more of a question of when versus whether there is more effort needed.

@Bilge
Copy link
Contributor Author

Bilge commented Oct 28, 2017

OK I'll leave this issue open but rename it to reflect we're waiting for a tag 👌

@Bilge Bilge changed the title Does not implement psr/container-implementation Version 2.x needs a tag Oct 28, 2017
@mbabker
Copy link
Contributor

mbabker commented Feb 9, 2018

PSR-11 support was backported onto 1.x and a 1.5.0 tag created.

@mbabker mbabker closed this as completed Feb 9, 2018
@Bilge
Copy link
Contributor Author

Bilge commented Feb 21, 2018

@mbabker Unfortunately I cannot use v1.5 because it is not logically compatible with 2.x. I normally use buildObject() to retrieve my services because they might be aliases or instances. However, v1.5 is missing the resolveAlias() call in that method, so it can never build objects that are aliases. I also cannot use the get() method because, although it will resolve aliases, it complains the object hasn't been registered with the container yet (i.e. it needs to be built). This is a deadlock and I cannot proceed with v1.5 at this time.

@mbabker
Copy link
Contributor

mbabker commented Feb 22, 2018

Some of these internals I think we can fix on the 1.x branch. buildObject() should definitely resolve aliases as it's a pretty common practice to alias a concrete class to an interface as we do for our default database service provider in that package, and we don't require aliases be mapped to registered services only.

@mbabker
Copy link
Contributor

mbabker commented Feb 25, 2018

33c66e4 should address that (as well as resolve #4 for 1.x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants