MASTER PR DO NOT MERGE

[bembelimen]

This PR exists to see the changes for the official PR to the Joomla! repo

DO NOT MERGE YET

[nibra]

You're missing the opportunity to separate the workflow from the components it is applied to. Although not all events exist, that might be needed to decouple things properly, the Workflow code should be in its own classes, like Workflow\Transit and Workflow\Filter. The trails in the affected components should be reduced to a single call with all needed parameters, so the pollution is minimal. Refactoring to event based workflow will be much easier then.

[nibra]

The changes in this file seem not to be related to Workflow.

[nibra]

This approach requires changes when states/conditions are added or removed. Better:
Define constants, eg.

class WorkflowConditions
{
    const PUBLISHED   =  1;
    const UNPUBLISHED =  0;
    const ARCHIVED    =  2;
    const TRASHED     = -2;
}

The loop should look like

$item->count = [];
foreach ($articles as $article)
{
    $item->count[$article->condition] = ($item->count[$article->condition] ?: 0) + $article->count;
}

In subsequent code, you'll access

$item->count[WorkflowConditions::PUBLISHED]

instead of

$item->count_published

[nibra]

Never use assignment in a condition.

[nibra]

Put he common part of the query before line 1033.