J4admin updated webcomponents #132
Conversation
|
Variables are superficially there. Updated the key and restored it in travis and have updated the config to the latest travis approved version in their docs. works in the master branch now. So update your branch to master here and see what happens I guess. Also can we remove the yarn-error log file from here please |
|
Just fixed the failures in the build quickly so hopefully we should get green when the branch is updated :) |
docs/callout.md
Outdated
| Message body is optional. If help documentation is available, consider adding a link to learn more | ||
| </div> | ||
| <div class="callout-footer"> | ||
| <a href="#" class="callout-link" target="blank">Learn more</a> |
There was a problem hiding this comment.
shouldnt this and all similar links be target="_blank"
|
I don't get the failure :( https://travis-ci.org/joomla-projects/custom-elements/builds/607091608#L445 we can see the username is there. Obviously the access key is encrypted so not showing - but it has the same all branches config as the username - and we can see in the master branch it's clearly working. |
|
@wilsonge Is this the reason for the failure?
|
|
Ahh yeah that would do it. They even mention sauce labs as an explicit example there 🤔 . So with travis we can't actually run the sauce lab tests until we've merged the pull request unless you've got write access to the project. Sounds fairly broken :) |
|
The following code is not correct because it may result in invalid markup By forcing the title to be a h3 then you can get an h3 directly after an h1 which is a serious accessibility failure There may be other instances of this error - I just highlighted one as an example |
|
@brianteeman we create But if its a serious accessibility issue then can you suggest alternative solution for this? For |
|
Yes its a serious accessibility issue so please make it a div AND also check that there are no other places that an Hx is used |
|
Ok I will update in accordion and check other places regarding the issue. |
|
The days when H tags were used based on sizing lol |
|
Hi @C-Lodder , |
|
I don't have the permissions to merge |
|
|
||
| joomla-callout::before { | ||
| content: ""; | ||
| width: 0px; |
There was a problem hiding this comment.
| width: 0px; | |
| width: 0; |
| joomla-callout::before { | ||
| content: ""; | ||
| width: 0px; | ||
| height: 0px; |
There was a problem hiding this comment.
| height: 0px; | |
| height: 0; |
| .accordion-panel-title:hover { | ||
| background-color: #edf4fa; } | ||
| .accordion-panel-title:focus { | ||
| box-shadow: 0px 0px 0px 2px #198df8; |
There was a problem hiding this comment.
| box-shadow: 0px 0px 0px 2px #198df8; | |
| box-shadow: 0 0 0 2px #198df8; |
| joomla-accordion.accordion .accordion-panel-title:hover { | ||
| background-color: #edf4fa; } | ||
| joomla-accordion.accordion .accordion-panel-title:focus { | ||
| box-shadow: 0px 0px 0px 2px #198df8; |
There was a problem hiding this comment.
| box-shadow: 0px 0px 0px 2px #198df8; | |
| box-shadow: 0 0 0 2px #198df8; |
| joomla-pagination .minimize-items-wrapper ul .pagination-item > a { | ||
| padding: 1px 5px; | ||
| border-bottom: 1px solid var(--bg-color); | ||
| border-radius: 0px; } |
There was a problem hiding this comment.
| border-radius: 0px; } | |
| border-radius: 0; } |
| joomla-accordion.accordion .accordion-panel-title:hover { | ||
| background-color: #edf4fa; } | ||
| joomla-accordion.accordion .accordion-panel-title:focus { | ||
| box-shadow: 0px 0px 0px 2px #198df8; |
There was a problem hiding this comment.
| box-shadow: 0px 0px 0px 2px #198df8; | |
| box-shadow: 0 0 0 2px #198df8; |
|
Oops the code changes I just commented on changing 0px to 0 should of course have been done in the scss file and not the generated css files |
| collapseHeader.setAttribute('area-expanded', 'false'); | ||
|
|
||
| const collapseHeaderTitle = this.getAttribute('collapse-title') === null ? this.getAttribute('type') : this.getAttribute('collapse-title'); | ||
| collapseHeader.innerHTML = collapseHeaderTitle; |
| createLink.className += ` ${item.getAttribute('activeClass')}`; | ||
| } | ||
| createLink.setAttribute('href', item.getAttribute('href')); | ||
| createLink.innerHTML = item.getAttribute('text'); |
| collapseHeader.classList.add('joomla-alert--collapse-header'); | ||
| collapseHeader.setAttribute('area-expanded', 'false'); | ||
| var collapseHeaderTitle = this.getAttribute('collapse-title') === null ? this.getAttribute('type') : this.getAttribute('collapse-title'); | ||
| collapseHeader.innerHTML = collapseHeaderTitle; |
| collapseHeader.setAttribute('area-expanded', 'false'); | ||
|
|
||
| const collapseHeaderTitle = this.getAttribute('collapse-title') === null ? this.getAttribute('type') : this.getAttribute('collapse-title'); | ||
| collapseHeader.innerHTML = collapseHeaderTitle; |
No description provided.