Avoid false positives creating a menu #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds support for multilingual
jatitoam
added a commit
that referenced
this pull request
Oct 7, 2015
Avoid false positives creating a menu
|
most of it, it's about timing, isn't it? |
|
yes most of the times, for my machine even 60 secs is not much 😛 |
| $I->waitForElement(['xpath' => "//a[contains(text()[normalize-space()], '$menuItem')]"], '60'); | ||
| $I->click(['xpath' => "//div[@id='collapseTypes']//a[contains(text()[normalize-space()], '$menuItem')]"]); | ||
| $I->debug('I switch back to the main window'); | ||
| $I->switchToIFrame(); |
There was a problem hiding this comment.
also this. Switching selenium back from the iframe:
At least in local seems to be more stable. Let's see what TravisCI has to say 😅
javigomez
added a commit
to javigomez/weblinks
that referenced
this pull request
Oct 7, 2015
This pull updates JoomlaBrowser joomla-projects/joomla-browser#66 to avoid false positives
yvesh
pushed a commit
to yvesh/weblinks
that referenced
this pull request
Oct 29, 2015
This pull updates JoomlaBrowser joomla-projects/joomla-browser#66 to avoid false positives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds support for multilingual
cc: @yvesh