wait for the folder to be deleted and then go further! #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 60 | ||
| ); | ||
| */ | ||
| $I->waitForJS("return jQuery('form#adminForm input[name=instDefault]').attr('disabled') == 'disabled';", 60); |
There was a problem hiding this comment.
@compojoom if you are trying to execute the click event of the "remove installation folder" button through javascript, then do you think we still need https://github.com/joomla-projects/joomla-browser/pull/74/files#diff-676cca4b1f4fdd04825e9c7ae7b54691R206
javigomez
added a commit
that referenced
this pull request
Oct 31, 2015
wait for the folder to be deleted and then go further!
javigomez
added a commit
to javigomez/weblinks
that referenced
this pull request
Oct 31, 2015
This pull adds Daniel fix at joomla-projects/joomla-browser#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix
#45
#51
I couldn't make it work with waitForElementChange, but this solution is basically the same with JS. The js is executed until the condition is met(the field becomes disabled). If this happens within 60s, then we go further...