This repository has been archived by the owner on May 26, 2020. It is now read-only.
Feature/add csrf token to client #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrammatiko
approved these changes
Feb 28, 2017
|
But CSRF is dead: https://scotthelme.co.uk/csrf-is-dead/ (if only all browsers supported that...) |
|
I think SameSite cookies are out of the scope of this project, the browser support ist horrible (http://caniuse.com/#search=SameSite) and i personally do not fully agree with that blog post in the age of stateless rest apis. |
|
Yes, it's way out of the scope of this project, but I won't create another issue that no-one will ever bother to even search a little about what this sameSite is... @laoneo can you merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for #104
Resolves issue #105