This repository has been archived by the owner on May 26, 2020. It is now read-only.
Move js code to files in media action plugins #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrammatiko
approved these changes
Apr 1, 2017
dgrammatiko
reviewed
Apr 1, 2017
| @@ -13,8 +13,8 @@ | |||
| JHtml::_('jquery.framework'); | |||
There was a problem hiding this comment.
we should remove that line
There was a problem hiding this comment.
It's still needed because the edit.js file is jQuery dependent. If somebody with more knowledge can fix that, would be nice to remove it.
There was a problem hiding this comment.
what the heck is edit.js?
There was a problem hiding this comment.
Ok replace the code with:
(function() {
"use strict";
document.addEventListener('DOMContentLoaded', function() {
var list = document.querySelectorAll('a[data-toggle="tab"]');
list.forEach(function(item) {
item.addEventListener('shown.bs.tab', function(event) {
if (event.relatedTarget) {
EventBus.dispatch('onDeactivate', this, event.relatedTarget.hash.replace('#attrib-', ''), document.getElementById('media-edit-file'));
}
EventBus.dispatch('onActivate', this, event.target.hash.replace('#attrib-', ''), document.getElementById('media-edit-file'));
})
})
});
})();
|
Hopefully it will make it easier for the JS cracks to work on the media action plugins 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #126.
Summary of Changes
Moves the js code from the layouts to js files. Additionally the lib files are stored locally with a minified and a dev version.