Object Calisthenics - best practise #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
reviewed
May 19, 2018
manual/basic-guidelines.md
Outdated
| 8. No Classes With More Than Two Instance Variables | ||
| 9. No Getters/Setters/Properties | ||
|
|
||
| for more info: |
brianteeman
approved these changes
May 19, 2018
This comment was marked as abuse.
This comment was marked as abuse.
|
always lookingg to find faults :( |
This comment was marked as abuse.
This comment was marked as abuse.
|
thank you for your words, these words really encourage |
This comment was marked as abuse.
This comment was marked as abuse.
|
nemesis |
|
If people like you who can develop code actually did instead of constantly
blaming those that try then joomla would be in a much better place.
…On Sat, 19 May 2018, 13:03 Nicola Galgano, ***@***.***> wrote:
Closed #236 <#236>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#236 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPH8eDEITi5yt9e2_p6H2hIm3FNrx5jks5tz_vkgaJpZM4UFqHf>
.
|
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
|
reopened, just the time to dress an anti-gas mask |
|
Object Calisthenics is heavily opinionated and unenforceable in the Joomla code without extremely disruptive B/C breaks. So no, this can't just be blindly copy/pasted in and enforced as part of the coding standard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per discussion on joomla/joomla-cms#20417 (comment)