[4.0] A11y changes for admin login (#17039)

* A11y admin login * Update default.php * Set JLOGIN string - Sentance case title
joomla · Jul 14, 2017 · 02a527a · 02a527a
1 parent 9bd62d5
commit 02a527a
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 11 deletions.
diff --git a/administrator/language/en-GB/en-GB.mod_login.ini b/administrator/language/en-GB/en-GB.mod_login.ini
@@ -7,7 +7,7 @@ MOD_LOGIN="Login Form"
 MOD_LOGIN_FIELD_USESECURE_DESC="Submit encrypted login data using HTTPS (encrypted HTTP connections with the https:// protocol prefix). Note, you must have HTTPS enabled on your server to utilise this option."
 MOD_LOGIN_FIELD_USESECURE_LABEL="Encrypt Login Form"
 MOD_LOGIN_LANGUAGE="Language"
-MOD_LOGIN_LOGIN="Log in"
+MOD_LOGIN_LOGIN_TITLE="Administrator Log In"
 MOD_LOGIN_XML_DESCRIPTION="This module displays a username and password login form. It should not be unpublished."
 MOD_LOGIN_REMIND="Forgot your username?"
 MOD_LOGIN_RESET="Forgot your password?"
diff --git a/administrator/modules/mod_login/tmpl/default.php b/administrator/modules/mod_login/tmpl/default.php
@@ -44,26 +44,24 @@
 	<fieldset>
 
 		<div class="form-group">
-			<label for="mod-login-username" class="sr-only"><?php echo JText::_('JGLOBAL_USERNAME'); ?></label>
+			<label for="mod-login-username"><?php echo JText::_('JGLOBAL_USERNAME'); ?></label>
 			<input
 				name="username"
 				id="mod-login-username"
 				type="text"
 				class="form-control input-full"
-				placeholder="<?php echo JText::_('JGLOBAL_USERNAME'); ?>"
 				autofocus
 			>
 		</div>
 
 		<div class="form-group">
-			<label for="mod-login-password" class="sr-only"><?php echo JText::_('JGLOBAL_PASSWORD'); ?></label>
+			<label for="mod-login-password"><?php echo JText::_('JGLOBAL_PASSWORD'); ?></label>
 			<div class="input-group">
 				<input
 					name="passwd"
 					id="mod-login-password"
 					type="password"
 					class="form-control input-full"
-					placeholder="<?php echo JText::_('JGLOBAL_PASSWORD'); ?>"
 				>
 				<span class="input-group-addon">
 					<span class="fa fa-eye" aria-hidden="true"></span>
@@ -73,15 +71,14 @@ class="form-control input-full"
 		</div>
 
 		<?php if (count($twofactormethods) > 1): ?>
-			<label for="mod-login-secretkey" class="sr-only"><?php echo JText::_('JGLOBAL_SECRETKEY'); ?></label>
+			<label for="mod-login-secretkey"><?php echo JText::_('JGLOBAL_SECRETKEY'); ?></label>
 			<div class="form-group">
 				<input
 					name="secretkey"
 					autocomplete="off"
 					id="mod-login-secretkey"
 					type="text"
 					class="form-control input-full"
-					placeholder="<?php echo JText::_('JGLOBAL_SECRETKEY'); ?>"
 				>
 			</div>
 		<?php endif; ?>
@@ -95,7 +92,7 @@ class="form-control input-full"
 
 		<div class="form-group">
 			<button class="btn btn-success btn-block btn-lg">
-				<span class="icon-lock icon-white"></span> <?php echo JText::_('MOD_LOGIN_LOGIN'); ?>
+				<span class="fa fa-lock icon-white"></span> <?php echo JText::_('MOD_LOGIN_LOGIN'); ?>
 			</button>
 		</div>
 

diff --git a/administrator/templates/atum/css/template-rtl.css.map b/administrator/templates/atum/css/template-rtl.css.map
diff --git a/administrator/templates/atum/css/template-rtl.min.css b/administrator/templates/atum/css/template-rtl.min.css
diff --git a/administrator/templates/atum/css/template.css.map b/administrator/templates/atum/css/template.css.map
diff --git a/administrator/templates/atum/css/template.min.css b/administrator/templates/atum/css/template.min.css
diff --git a/administrator/templates/atum/login.php b/administrator/templates/atum/login.php
@@ -80,7 +80,7 @@
 			</noscript>
 			<?php // Begin Content ?>
 			<div id="element-box" class="login card card-block">
-				<h2 class="text-center mt-1 mb-2"><?php echo JText::_('MOD_LOGIN_LOGIN'); ?></h2>
+				<h1 class="text-center mt-1 mb-4"><?php echo JText::_('MOD_LOGIN_LOGIN_TITLE'); ?></h1>
 				<jdoc:include type="message" />
 				<jdoc:include type="component" />
 			</div>

diff --git a/administrator/templates/atum/scss/blocks/_global.scss b/administrator/templates/atum/scss/blocks/_global.scss
@@ -19,6 +19,10 @@ h6 {
   font-weight: bold;
 }
 
+h1 {
+  font-weight: normal;
+}
+
 small,
 .small {
   font-size: $font-size-small;