replace return '' by throw

joomla · Oct 26, 2020 · 04c3854 · 04c3854
1 parent 1df96a3
commit 04c3854
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/administrator/language/en-GB/lib_joomla.ini b/administrator/language/en-GB/lib_joomla.ini
@@ -502,7 +502,8 @@ JLIB_HTML_FEATURED_ITEM="Featured."
 JLIB_HTML_FEATURED_PENDING_ITEM="Featured, but is Pending."
 JLIB_HTML_FEATURED_STARTED="Start: %s"
 JLIB_HTML_GOTO_PAGE="Go to page %s"
-JLIB_HTML_GOTO_POSITION="Go to %s page"
+JLIB_HTML_GOTO_POSITION="Go to %s page."
+JLIB_HTML_ICONS_NO_ICON="No icon provided
 JLIB_HTML_MOVE_DOWN="Move Down"
 JLIB_HTML_MOVE_UP="Move Up"
 JLIB_HTML_NO_PARAMETERS_FOR_THIS_ITEM="There are no parameters for this item."

diff --git a/libraries/src/HTML/Helpers/Icons.php b/libraries/src/HTML/Helpers/Icons.php
@@ -12,6 +12,7 @@
 
 use Joomla\CMS\Factory;
 use Joomla\CMS\HTML\HTMLHelper;
+use Joomla\CMS\Language\Text;
 use Joomla\CMS\Layout\FileLayout;
 use Joomla\Utilities\ArrayHelper;
 
@@ -31,13 +32,15 @@ abstract class Icons
 	 *
 	 * @return  string
 	 *
+	 * @throws  \InvalidArgumentException
+	 *
 	 * @since   __DEPLOY_VERSION__
 	 */
 	public static function icon(string $icon = '', string $srOnly = '', array $attribs = [])
 	{
 		if ($icon === '')
 		{
-			return '';
+			throw new \InvalidArgumentException(Text::_('JLIB_HTML_ICONS_NO_ICON'));
 		}
 
 		if (isset($attribs['class']))