not a good idea to use 'this' inside 'sendPermissions', use

'event.target' instead
joomla · Nov 21, 2016 · 04d2903 · 04d2903
1 parent 58aadb2
commit 04d2903
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/media/system/js/permissions-uncompressed.js b/media/system/js/permissions-uncompressed.js
@@ -5,7 +5,7 @@ function sendPermissions(event) {
 	'use strict';
 
 	// set the icon while storing the values
-	var icon = document.getElementById('icon_' + this.id);
+	var icon = document.getElementById('icon_' + event.target.id);
 	icon.removeAttribute('class');
 	icon.setAttribute('style', 'background: url(../media/system/images/modal/spinner.gif); display: inline-block; width: 16px; height: 16px');
 
@@ -16,7 +16,7 @@ function sendPermissions(event) {
 	var option = getUrlParam('option');
 	var view = getUrlParam('view');
 	var title = component;
-	var value = this.value;
+	var value = event.target.value;
 
 	if (option == 'com_config' && component == false && extension == false)
 	{
@@ -34,7 +34,7 @@ function sendPermissions(event) {
 		title = document.getElementById('jform_title').value;
 	}
 
-	var id = this.id.replace('jform_rules_', '');
+	var id = event.target.id.replace('jform_rules_', '');
 	var lastUnderscoreIndex = id.lastIndexOf('_');
 
 	var permission_data = {

diff --git a/media/system/js/permissions.js b/media/system/js/permissions.js