Merge branch 'staging' into fix-media-manager

joomla · Jun 17, 2019 · 07d5e1c · 07d5e1c
2 parents 5722fbe + cc89a6e
commit 07d5e1c
Show file tree

Hide file tree

Showing 29 changed files with 292 additions and 188 deletions.
diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@ Build Status
 ---------------------
 | Travis-CI  | Drone-CI | AppVeyor |
 | ------------- | ------------- | ------------- |
-| [![Build Status](https://travis-ci.org/joomla/joomla-cms.svg?branch=staging)](https://travis-ci.org/joomla/joomla-cms)  | [![Build Status](http://213.160.72.75/api/badges/joomla/joomla-cms/status.svg)](http://213.160.72.75/joomla/joomla-cms)  | [![Build status](https://ci.appveyor.com/api/projects/status/bpcxulw6nnxlv8kb/branch/staging?svg=true)](https://ci.appveyor.com/project/joomla/joomla-cms)  |
+| [![Build Status](https://travis-ci.org/joomla/joomla-cms.svg?branch=staging)](https://travis-ci.org/joomla/joomla-cms)  | [![Build Status](https://ci.joomla.org/api/badges/joomla/joomla-cms/status.svg)](https://ci.joomla.org/joomla/joomla-cms)  | [![Build status](https://ci.appveyor.com/api/projects/status/bpcxulw6nnxlv8kb/branch/staging?svg=true)](https://ci.appveyor.com/project/joomla/joomla-cms)  |
 
 What is this?
 ---------------------

diff --git a/administrator/components/com_admin/sql/updates/mysql/3.9.8-2019-06-15.sql b/administrator/components/com_admin/sql/updates/mysql/3.9.8-2019-06-15.sql
@@ -0,0 +1,3 @@
+ALTER TABLE `#__template_styles` DROP INDEX `idx_home`;
+ALTER TABLE `#__template_styles` MODIFY `home` tinyint(1) unsigned NOT NULL DEFAULT 0;
+ALTER TABLE `#__template_styles` ADD INDEX `idx_home` (`home`);
diff --git a/administrator/components/com_admin/sql/updates/postgresql/3.9.8-2019-06-15.sql b/administrator/components/com_admin/sql/updates/postgresql/3.9.8-2019-06-15.sql
@@ -0,0 +1,4 @@
+DROP INDEX IF EXISTS "#__template_styles_idx_home";
+ALTER TABLE "#__template_style" ALTER COLUMN "home" TYPE smallint;
+ALTER TABLE "#__template_style" ALTER COLUMN "home" SET DEFAULT 0;
+CREATE INDEX "#__template_styles_idx_home" ON "#__template_style" ("home");
diff --git a/administrator/components/com_admin/sql/updates/sqlazure/3.9.8-2019-06-15.sql b/administrator/components/com_admin/sql/updates/sqlazure/3.9.8-2019-06-15.sql
@@ -0,0 +1,7 @@
+DROP INDEX [idx_home] ON [#__template_styles];
+ALTER TABLE [#__template_styles] ALTER COLUMN [home] [tyinint] NOT NULL;
+CREATE NONCLUSTERED INDEX [idx_home] ON [#__template_styles]
+(
+	[home] ASC
+)WITH (STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, DROP_EXISTING = OFF, ONLINE = OFF);
+ALTER TABLE [#__template_styles] ADD DEFAULT (0) FOR [home];
diff --git a/administrator/components/com_installer/models/extension.php b/administrator/components/com_installer/models/extension.php
@@ -117,10 +117,10 @@ protected function _getList($query, $limitstart = 0, $limit = 0)
 			$total = count($result);
 			$this->cache[$this->getStoreId('getTotal')] = $total;
 
-			if ($total < $limitstart)
+			if ($total <= $limitstart)
 			{
 				$limitstart = 0;
-				$this->setState('list.start', 0);
+				$this->setState('list.limitstart', 0);
 			}
 
 			return array_slice($result, $limitstart, $limit ?: null);

diff --git a/administrator/components/com_media/views/images/tmpl/default.php b/administrator/components/com_media/views/images/tmpl/default.php
@@ -65,28 +65,30 @@
 ?>
 <div class="container-popup">
 
-	<form action="index.php?option=com_media&amp;asset=<?php echo $asset; ?>&amp;author=<?php echo $author; ?>" class="form-vertical" id="imageForm" method="post" enctype="multipart/form-data">
+	<form action="index.php?option=com_media&amp;asset=<?php echo $asset; ?>&amp;author=<?php echo $author; ?>" class="form-horizontal" id="imageForm" method="post" enctype="multipart/form-data">
 
 		<div id="messages" style="display: none;">
 			<span id="message"></span><?php echo JHtml::_('image', 'media/dots.gif', '...', array('width' => 22, 'height' => 12), true); ?>
 		</div>
 
 		<div class="well">
-			<div class="row">
-				<div class="span12 control-group">
+			<div class="row-fluid">
+				<div class="span8 control-group">
 					<div class="control-label">
-						<label class="control-label" for="folder"><?php echo JText::_('COM_MEDIA_DIRECTORY'); ?></label>
+						<label for="folder"><?php echo JText::_('COM_MEDIA_DIRECTORY'); ?></label>
 					</div>
 					<div class="controls">
 						<?php echo $this->folderList; ?>
 						<button class="btn" type="button" id="upbutton" title="<?php echo JText::_('COM_MEDIA_DIRECTORY_UP'); ?>"><?php echo JText::_('COM_MEDIA_UP'); ?></button>
 					</div>
 				</div>
-				<div class="pull-right">
-					<button class="btn btn-success button-save-selected" type="button" <?php if (!empty($onClick)) :
-					// This is for Mootools compatibility ?>onclick="<?php echo $onClick; ?>"<?php endif; ?> data-dismiss="modal"><?php echo JText::_('COM_MEDIA_INSERT'); ?></button>
-					<button class="btn button-cancel" type="button" onclick="window.parent.jQuery('.modal.in').modal('hide');<?php if (!empty($onClick)) :
-						// This is for Mootools compatibility ?>parent.jModalClose();<?php endif ?>" data-dismiss="modal"><?php echo JText::_('JCANCEL'); ?></button>
+				<div class="span4 control-group">
+					<div class="pull-right">
+						<button class="btn btn-success button-save-selected" type="button" <?php if (!empty($onClick)) :
+							// This is for Mootools compatibility ?>onclick="<?php echo $onClick; ?>"<?php endif; ?> data-dismiss="modal"><?php echo JText::_('COM_MEDIA_INSERT'); ?></button>
+						<button class="btn button-cancel" type="button" onclick="window.parent.jQuery('.modal.in').modal('hide');<?php if (!empty($onClick)) :
+							// This is for Mootools compatibility ?>parent.jModalClose();<?php endif ?>" data-dismiss="modal"><?php echo JText::_('JCANCEL'); ?></button>
+					</div>
 				</div>
 			</div>
 		</div>
@@ -95,15 +97,20 @@
 
 		<div class="well">
 			<div class="row-fluid">
-				<div class="span6 control-group">
+				<div class="span12 control-group">
 					<div class="control-label">
 						<label for="f_url"><?php echo JText::_('COM_MEDIA_IMAGE_URL'); ?></label>
 					</div>
 					<div class="controls">
 						<input type="text" id="f_url" value="" />
 					</div>
 				</div>
-				<?php if (!$this->state->get('field.id')) : ?>
+			</div>
+		</div>
+
+		<?php if (!$this->state->get('field.id')) : ?>
+			<div class="well">
+				<div class="row-fluid">
 					<div class="span6 control-group">
 						<div class="control-label">
 							<label title="<?php echo JText::_('COM_MEDIA_ALIGN_DESC'); ?>" class="noHtmlTip" for="f_align"><?php echo JText::_('COM_MEDIA_ALIGN'); ?></label>
@@ -117,9 +124,7 @@
 							</select>
 						</div>
 					</div>
-				<?php endif; ?>
-			</div>
-			<?php if (!$this->state->get('field.id')) : ?>
+				</div>
 				<div class="row-fluid">
 					<div class="span6 control-group">
 						<div class="control-label">
@@ -161,13 +166,11 @@
 						</div>
 					</div>
 				</div>
-			<?php endif; ?>
-
 			<input type="hidden" id="dirPath" name="dirPath" />
 			<input type="hidden" id="f_file" name="f_file" />
 			<input type="hidden" id="tmpl" name="component" />
-
 		</div>
+		<?php endif; ?>
 	</form>
 
 	<?php if ($user->authorise('core.create', 'com_media')) : ?>

diff --git a/administrator/components/com_media/views/imageslist/tmpl/default.php b/administrator/components/com_media/views/imageslist/tmpl/default.php
@@ -27,7 +27,6 @@
 			@media (max-width: 767px) {
 				li.imgOutline.thumbnail.height-80.width-80.center {
 					float: right;
-					margin-right: 15px;
 				}
 			}
 		'
@@ -40,7 +39,6 @@
 			@media (max-width: 767px) {
 				li.imgOutline.thumbnail.height-80.width-80.center {
 					float: left;
-					margin-left: 15px;
 				}
 			}
 		'

diff --git a/administrator/templates/isis/css/template-rtl.css b/administrator/templates/isis/css/template-rtl.css
@@ -7766,15 +7766,9 @@ ul.manager .height-50 .icon-folder-2 {
 	line-height: 35px;
 	font-size: 30px;
 }
-#imageForm {
-	margin: -25px 0 0;
-}
 #imageForm .well {
 	margin-bottom: 5px;
 }
-.thumbnails-media {
-	margin-left: 0;
-}
 .thumbnails-media .thumbnail {
 	background-color: #f4f4f4;
 	border-radius: 3px;
@@ -7783,8 +7777,7 @@ ul.manager .height-50 .icon-folder-2 {
 	padding: 0px;
 	height: 100px;
 	width: 100px;
-	margin: 8px 16px;
-	margin-left: 0 !important;
+	margin: 8px;
 	position: relative;
 	text-align: center;
 	overflow: hidden;
@@ -7969,6 +7962,7 @@ ul.manager .height-50 .icon-folder-2 {
 }
 #mediamanager-form {
 	margin: 0 -10px;
+	overflow-x: hidden;
 }
 #mediamanager-form > .muted {
 	padding: 0px;
@@ -7980,10 +7974,14 @@ ul.manager .height-50 .icon-folder-2 {
 #mediamanager-form .checkbox input {
 	margin-top: 3px;
 }
+#mediamanager-form .thumbnails {
+	margin: 0 -8px;
+	overflow-x: hidden;
+}
 #mediamanager-form .thumbnails .thumbnail {
 	height: 120px;
 	width: 120px;
-	margin: 0 18px 18px 0;
+	margin: 8px;
 }
 #mediamanager-form .thumbnails .imgThumb label,
 #mediamanager-form .thumbnails .imgTotal {
@@ -8047,6 +8045,7 @@ body.modal-open {
 	padding: 0;
 	width: 100%;
 	height: auto;
+	max-height: none;
 }
 .modal-body .container-fluid {
 	padding-top: 15px;
@@ -8065,7 +8064,10 @@ body.modal-open {
 	}
 }
 .container-popup {
-	padding: 28px 10px 10px 10px;
+	padding: 10px;
+}
+.field-media-wrapper iframe {
+	max-height: 75vh;
 }
 body .navbar,
 body .navbar-fixed-top {

diff --git a/administrator/templates/isis/css/template.css b/administrator/templates/isis/css/template.css
@@ -7766,15 +7766,9 @@ ul.manager .height-50 .icon-folder-2 {
 	line-height: 35px;
 	font-size: 30px;
 }
-#imageForm {
-	margin: -25px 0 0;
-}
 #imageForm .well {
 	margin-bottom: 5px;
 }
-.thumbnails-media {
-	margin-left: 0;
-}
 .thumbnails-media .thumbnail {
 	background-color: #f4f4f4;
 	border-radius: 3px;
@@ -7783,8 +7777,7 @@ ul.manager .height-50 .icon-folder-2 {
 	padding: 0px;
 	height: 100px;
 	width: 100px;
-	margin: 8px 16px;
-	margin-left: 0 !important;
+	margin: 8px;
 	position: relative;
 	text-align: center;
 	overflow: hidden;
@@ -7969,6 +7962,7 @@ ul.manager .height-50 .icon-folder-2 {
 }
 #mediamanager-form {
 	margin: 0 -10px;
+	overflow-x: hidden;
 }
 #mediamanager-form > .muted {
 	padding: 0px;
@@ -7980,10 +7974,14 @@ ul.manager .height-50 .icon-folder-2 {
 #mediamanager-form .checkbox input {
 	margin-top: 3px;
 }
+#mediamanager-form .thumbnails {
+	margin: 0 -8px;
+	overflow-x: hidden;
+}
 #mediamanager-form .thumbnails .thumbnail {
 	height: 120px;
 	width: 120px;
-	margin: 0 18px 18px 0;
+	margin: 8px;
 }
 #mediamanager-form .thumbnails .imgThumb label,
 #mediamanager-form .thumbnails .imgTotal {
@@ -8047,6 +8045,7 @@ body.modal-open {
 	padding: 0;
 	width: 100%;
 	height: auto;
+	max-height: none;
 }
 .modal-body .container-fluid {
 	padding-top: 15px;
@@ -8065,7 +8064,10 @@ body.modal-open {
 	}
 }
 .container-popup {
-	padding: 28px 10px 10px 10px;
+	padding: 10px;
+}
+.field-media-wrapper iframe {
+	max-height: 75vh;
 }
 body .navbar,
 body .navbar-fixed-top {

diff --git a/administrator/templates/isis/html/layouts/joomla/form/field/media.php b/administrator/templates/isis/html/layouts/joomla/form/field/media.php
@@ -93,7 +93,7 @@
 	data-url="<?php echo $url; ?>"
 	data-modal=".modal"
 	data-modal-width="100%"
-	data-modal-height="400px"
+	data-modal-height="645px"
 	data-input=".field-media-input"
 	data-button-select=".button-select"
 	data-button-clear=".button-clear"
@@ -112,7 +112,6 @@
 		array(
 			'title'       => JText::_('JLIB_FORM_CHANGE_IMAGE'),
 			'closeButton' => true,
-			'footer'      => '<button type="button" class="btn" data-dismiss="modal">' . JText::_('JCANCEL') . '</button>',
 		)
 	);
 

diff --git a/administrator/templates/isis/less/blocks/_media.less b/administrator/templates/isis/less/blocks/_media.less
@@ -9,14 +9,12 @@ ul.manager .height-50 .icon-folder-2 {
 }
 
 #imageForm {
-	margin: -25px 0 0;
 	.well {
 		margin-bottom: 5px;
 	}
 }
 .thumbnails-media {
 	@thumbSize:100px;
-	margin-left: 0;
 	.thumbnail {
 		background-color: #f4f4f4;
 		border-radius: @inputBorderRadius;
@@ -25,8 +23,7 @@ ul.manager .height-50 .icon-folder-2 {
 		padding: 0px;
 		height: @thumbSize;
 		width: @thumbSize;
-		margin: 8px 16px;
-		margin-left: 0 !important;
+		margin: 8px;
 		position: relative;
 		text-align: center;
 		overflow: hidden;
@@ -203,6 +200,7 @@ ul.manager .height-50 .icon-folder-2 {
 }
 #mediamanager-form {
 	margin: 0 -10px;
+	overflow-x: hidden;
 	> .muted {
 		padding: 0px;
 	}
@@ -214,10 +212,12 @@ ul.manager .height-50 .icon-folder-2 {
 		}
 	}
 	.thumbnails {
+		margin: 0 -8px;
+		overflow-x: hidden;
 		.thumbnail {
 			height: 120px;
 			width: 120px;
-			margin: 0 18px 18px 0;
+			margin: 8px
 		}
 		.imgThumb label, .imgTotal {
 			line-height: 120px;

diff --git a/administrator/templates/isis/less/blocks/_modals.less b/administrator/templates/isis/less/blocks/_modals.less
@@ -25,6 +25,7 @@ body.modal-open {
   padding: 0;
   width: 100%;
   height: auto;
+  max-height: none;
   .container-fluid {
     padding-top: 15px;
     padding-bottom: 15px;
@@ -46,7 +47,12 @@ body.modal-open {
 	}
 }
 
-/* Component pop-up */
+// Component pop-up
 .container-popup {
-	padding: 28px 10px 10px 10px;
+	padding: 10px;
+}
+
+// Media modal
+.field-media-wrapper iframe {
+  max-height: 75vh;
 }