Use the cached manifest on the com_modules select model

administrator/components/com_modules/models/select.php

@@ -84,6 +84,7 @@ protected function getListQuery()
 				'a.extension_id, a.name, a.element AS module'
 			)
 		);
+		$query->select('a.manifest_cache AS manifest');
 		$query->from($db->quoteName('#__extensions') . ' AS a');
 
 		// Filter by module
@@ -119,24 +120,14 @@ public function getItems()
 		// and load language support.
 		foreach ($items as &$item)
 		{
-			$path = JPath::clean($client->path . '/modules/' . $item->module . '/' . $item->module . '.xml');
-
-			if (file_exists($path))
-			{
-				$item->xml = simplexml_load_file($path);
-			}
-			else
-			{
-				$item->xml = null;
-			}
-
 			// 1.5 Format; Core files or language packs then
 			// 1.6 3PD Extension Support
 			$lang->load($item->module . '.sys', $client->path, null, false, true)
 				|| $lang->load($item->module . '.sys', $client->path . '/modules/' . $item->module, null, false, true);
 			$item->name = JText::_($item->name);
 
-			if (isset($item->xml) && $text = trim($item->xml->description))
+			$item->manifest = json_decode($item->manifest);
+			if (isset($item->manifest) && $text = trim($item->manifest->description))
 			{
 				$item->desc = JText::_($text);
 			}
@@ -148,8 +139,6 @@ public function getItems()
 
 		$items = JArrayHelper::sortObjects($items, 'name', 1, true, true);
 
-		// TODO: Use the cached XML from the extensions table?
-
 		return $items;
 	}
 }