Simplify active id $value control

joomla · May 18, 2016 · 29a6bf9 · 29a6bf9
1 parent 2214bdc
commit 29a6bf9
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 30 deletions.
diff --git a/administrator/components/com_categories/models/fields/modal/category.php b/administrator/components/com_categories/models/fields/modal/category.php
@@ -49,14 +49,7 @@ protected function getInput()
 		JFactory::getLanguage()->load('com_categories', JPATH_ADMINISTRATOR);
 
 		// The active category id field.
-		if (0 == (int) $this->value)
-		{
-			$value = '';
-		}
-		else
-		{
-			$value = (int) $this->value;
-		}
+		$value = (int) $this->value > 0 ? (int) $this->value : '';
 
 		// Build the script.
 		$script = array();
@@ -130,13 +123,13 @@ protected function getInput()
 		$urlSelect = $linkCategories . '&amp;' . JSession::getFormToken() . '=1';
 		$urlEdit   = $linkCategory . '&amp;id=' . $value . '&amp;' . JSession::getFormToken() . '=1';
 
-		if ((int) $this->value > 0)
+		if ($value)
 		{
 			$db    = JFactory::getDbo();
 			$query = $db->getQuery(true)
 				->select($db->quoteName('title'))
 				->from($db->quoteName('#__categories'))
-				->where($db->quoteName('id') . ' = ' . (int) $this->value);
+				->where($db->quoteName('id') . ' = ' . (int) $value);
 			$db->setQuery($query);
 
 			try

diff --git a/administrator/components/com_contact/models/fields/modal/contact.php b/administrator/components/com_contact/models/fields/modal/contact.php
@@ -40,14 +40,7 @@ protected function getInput()
 		JFactory::getLanguage()->load('com_contact', JPATH_ADMINISTRATOR);
 
 		// The active contact id field.
-		if (0 == (int) $this->value)
-		{
-			$value = '';
-		}
-		else
-		{
-			$value = (int) $this->value;
-		}
+		$value = (int) $this->value > 0 ? (int) $this->value : '';
 
 		// Build the script.
 		$script = array();
@@ -127,13 +120,13 @@ protected function getInput()
 		$urlSelect = $linkContacts . '&amp;' . JSession::getFormToken() . '=1';
 		$urlEdit   = $linkContact . '&amp;id=' . $value . '&amp;' . JSession::getFormToken() . '=1';
 
-		if ((int) $this->value > 0)
+		if ($value)
 		{
 			$db    = JFactory::getDbo();
 			$query = $db->getQuery(true)
 				->select($db->quoteName('name'))
 				->from($db->quoteName('#__contact_details'))
-				->where($db->quoteName('id') . ' = ' . (int) $this->value);
+				->where($db->quoteName('id') . ' = ' . (int) $value);
 			$db->setQuery($query);
 
 			try

diff --git a/administrator/components/com_newsfeeds/models/fields/modal/newsfeed.php b/administrator/components/com_newsfeeds/models/fields/modal/newsfeed.php
@@ -40,14 +40,7 @@ protected function getInput()
 		JFactory::getLanguage()->load('com_newsfeeds', JPATH_ADMINISTRATOR);
 
 		// The active newsfeed id field.
-		if (0 == (int) $this->value)
-		{
-			$value = '';
-		}
-		else
-		{
-			$value = (int) $this->value;
-		}
+		$value = (int) $this->value > 0 ? (int) $this->value : '';
 
 		// Build the script.
 		$script = array();
@@ -127,13 +120,13 @@ protected function getInput()
 		$urlSelect = $linkNewsfeeds . '&amp;' . JSession::getFormToken() . '=1';
 		$urlEdit   = $linkNewsfeed . '&amp;id=' . $value . '&amp;' . JSession::getFormToken() . '=1';
 
-		if ((int) $this->value > 0)
+		if ($value)
 		{
 			$db    = JFactory::getDbo();
 			$query = $db->getQuery(true)
 				->select($db->quoteName('name'))
 				->from($db->quoteName('#__newsfeeds'))
-				->where($db->quoteName('id') . ' = ' . (int) $this->value);
+				->where($db->quoteName('id') . ' = ' . (int) $value);
 			$db->setQuery($query);
 
 			try